Add support for processing incoming mail messages in reply to message

notifications and diary comment notifications, turning the maill messages
into reply messages through the site messaging system.

diff --git a/app/models/diary_comment.rb b/app/models/diary_comment.rb
index aaf48be4fdcc8c9f200b41efceabfc74e8058f09..0013606d06b55afa885306e38b7777f16518016b 100644 (file)
--- a/app/models/diary_comment.rb
+++ b/app/models/diary_comment.rb
@@ -4,4 +4,13 @@ class DiaryComment < ActiveRecord::Base
 
   validates_presence_of :body
   validates_associated :diary_entry
+
+  def digest
+    md5 = Digest::MD5.new
+    md5 << diary_entry_id.to_s
+    md5 << user_id.to_s
+    md5 << created_at.xmlschema
+    md5 << body
+    md5.hexdigest
+  end
 end

diff --git a/app/models/message.rb b/app/models/message.rb
index 464c5502837b56c5ffdf409ff32288f6b5779cac..98346d7c7231f4c1f7d5f44738313ebeea61c5e2 100644 (file)
--- a/app/models/message.rb
+++ b/app/models/message.rb
@@ -9,4 +9,14 @@ class Message < ActiveRecord::Base
   validates_inclusion_of :message_read, :in => [ true, false ]
   validates_associated :sender, :recipient
   validates_as_utf8 :title
+
+  def digest
+    md5 = Digest::MD5.new
+    md5 << from_user_id.to_s
+    md5 << to_user_id.to_s
+    md5 << sent_on.xmlschema
+    md5 << title
+    md5 << body
+    md5.hexdigest
+  end
 end

diff --git a/app/models/notifier.rb b/app/models/notifier.rb
index 35b521e1fdfdd4918f82f3aa604a97a4f7b331d4..6ba90ce58954b0096cc621ba260bb80e0f86a4ce 100644 (file)
--- a/app/models/notifier.rb
+++ b/app/models/notifier.rb
@@ -47,6 +47,7 @@ class Notifier < ActionMailer::Base
   
   def message_notification(message)
     common_headers message.recipient
+    from_header message.sender.display_name, "m", message.id, message.digest
     subject I18n.t('notifier.message_notification.subject', :user => message.sender.display_name, :locale => locale)
     body :to_user => message.recipient.display_name,
          :from_user => message.sender.display_name,
@@ -62,6 +63,7 @@ class Notifier < ActionMailer::Base
 
   def diary_comment_notification(comment)
     common_headers comment.diary_entry.user
+    from_header comment.user.display_name, "c", comment.id, comment.digest
     subject I18n.t('notifier.diary_comment_notification.subject', :user => comment.user.display_name, :locale => locale)
     body :to_user => comment.diary_entry.user.display_name,
          :from_user => comment.user.display_name,
@@ -103,8 +105,14 @@ private
   def common_headers(recipient)
     recipients recipient.email
     locale recipient.preferred_language_from(I18n.available_locales)
-    from "webmaster@openstreetmap.org"
+    from "OpenStreetMap <webmaster@openstreetmap.org>"
     headers "return-path" => "bounces@openstreetmap.org",
             "Auto-Submitted" => "auto-generated"
   end
+
+  def from_header(name, type, id, digest)
+    if domain = APP_CONFIG['messages_domain']
+      from "#{name} <#{type}-#{id}-#{digest[0,6]}@#{domain}>"
+    end
+  end
 end

diff --git a/config/application.yml b/config/application.yml
index a478217a40d1db39241bf7e57dfb7b36896ce8aa..4983d362726763ecf8b3e5f52c077808f6f394bd 100644 (file)
--- a/config/application.yml
+++ b/config/application.yml
@@ -19,6 +19,8 @@ standard_settings: &standard_settings
   user_block_periods: [0, 1, 3, 6, 12, 24, 48, 96]
   # Rate limit for message sending
   max_messages_per_hour: 60
+  # Domain for handling message replies
+  #messages_domain: "messages.openstreetmap.org"
  
 development:
   <<: *standard_settings

diff --git a/script/deliver-message b/script/deliver-message
new file mode 100755 (executable)
index 0000000..d3af5ff
--- /dev/null
+++ b/script/deliver-message
@@ -0,0 +1,32 @@
+#!/usr/bin/env ruby
+
+require File.dirname(__FILE__) + '/../config/environment'
+require 'mailread'
+
+exit 0 unless recipient = ARGV[0].match(/^([cm])-(\d+)-(.*)$/)
+
+if recipient[1] == "c"
+  comment = DiaryComment.find(recipient[2])
+  digest = comment.digest
+  from = comment.diary_entry.user
+  to = comment.user
+else
+  message = Message.find(recipient[2])
+  digest = message.digest
+  from = message.recipient
+  to = message.sender
+end
+
+exit 0 unless recipient[3] == digest[0,6]
+
+mail = Mail.new(STDIN)
+
+message = Message.new(:sender => from, :recipient => to,
+                      :sent_on => Time.now.getutc,
+                      :title => mail["Subject"],
+                      :body => mail.body.join("\n"))
+message.save!
+
+Notifier::deliver_message_notification(message)
+
+exit 0