]> git.openstreetmap.org Git - rails.git/commitdiff
Fix new rubocop warnings
authorTom Hughes <tom@compton.nu>
Tue, 17 Nov 2020 08:17:34 +0000 (08:17 +0000)
committerTom Hughes <tom@compton.nu>
Tue, 17 Nov 2020 08:17:34 +0000 (08:17 +0000)
app/validators/characters_validator.rb
lib/gpx.rb

index 94d340731ada18edf952ccaf887b3fe1396af246..837e3e6cc89628fe130b52b09816fc73341f54e2 100644 (file)
@@ -3,7 +3,7 @@ class CharactersValidator < ActiveModel::EachValidator
   INVALID_URL_CHARS = "/;.,?%#".freeze
 
   def validate_each(record, attribute, value)
-    record.errors[attribute] << (options[:message] || I18n.t("validations.invalid_characters")) if /[#{INVALID_CHARS}]/.match?(value)
-    record.errors[attribute] << (options[:message] || I18n.t("validations.url_characters", :characters => INVALID_URL_CHARS)) if options[:url_safe] && /[#{INVALID_URL_CHARS}]/.match?(value)
+    record.errors[attribute] << (options[:message] || I18n.t("validations.invalid_characters")) if /[#{INVALID_CHARS}]/o.match?(value)
+    record.errors[attribute] << (options[:message] || I18n.t("validations.url_characters", :characters => INVALID_URL_CHARS)) if options[:url_safe] && /[#{INVALID_URL_CHARS}]/o.match?(value)
   end
 end
index 1a1d0b99659aa8be2f0c09c80a56cb877da2aac8..d0607233a2d7f4f108ce35f0b86122c71956a0c3 100644 (file)
@@ -37,7 +37,7 @@ module GPX
     end
 
     def points(&block)
-      return enum_for(:points) unless block_given?
+      return enum_for(:points) unless block
 
       @possible_points = 0
       @actual_points = 0