Fix new rubocop warnings

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 79c6e6134a007843d0ca5e2b04d1138855dc47f6..5f36e262b9d24677f2cff1497e0d967718b471fe 100644 (file)
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -21,15 +21,15 @@ module ApplicationHelper
     id = "#{object_name}_#{method}"
     type = options.delete(:format) || "markdown"
 
-    content_tag(:div, :id => "#{id}_container", :class => "richtext_container") do
-      output_buffer << content_tag(:div, :id => "#{id}_content", :class => "richtext_content") do
+    tag.div(:id => "#{id}_container", :class => "richtext_container") do
+      output_buffer << tag.div(:id => "#{id}_content", :class => "richtext_content") do
         output_buffer << text_area(object_name, method, options.merge("data-preview-url" => preview_url(:type => type)))
-        output_buffer << content_tag(:div, "", :id => "#{id}_preview", :class => "richtext_preview richtext")
+        output_buffer << tag.div("", :id => "#{id}_preview", :class => "richtext_preview richtext")
       end
 
-      output_buffer << content_tag(:div, :id => "#{id}_help", :class => "richtext_help") do
+      output_buffer << tag.div(:id => "#{id}_help", :class => "richtext_help") do
         output_buffer << render("site/#{type}_help")
-        output_buffer << content_tag(:div, :class => "buttons") do
+        output_buffer << tag.div(:class => "buttons") do
           output_buffer << submit_tag(I18n.t("site.richtext_area.edit"), :id => "#{id}_doedit", :class => "richtext_doedit deemphasize", :disabled => true)
           output_buffer << submit_tag(I18n.t("site.richtext_area.preview"), :id => "#{id}_dopreview", :class => "richtext_dopreview deemphasize")
         end
@@ -46,11 +46,11 @@ module ApplicationHelper
   end
 
   def friendly_date(date)
-    content_tag(:span, time_ago_in_words(date), :title => l(date, :format => :friendly))
+    tag.span(time_ago_in_words(date), :title => l(date, :format => :friendly))
   end
 
   def friendly_date_ago(date)
-    content_tag(:span, time_ago_in_words(date, :scope => :'datetime.distance_in_words_ago'), :title => l(date, :format => :friendly))
+    tag.span(time_ago_in_words(date, :scope => :'datetime.distance_in_words_ago'), :title => l(date, :format => :friendly))
   end
 
   def body_class

diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index 2f61631b7d2c356f28b5948277dca98258424ae4..cf2bc64742dc6faebb72e511a7c9ebb958b537e2 100644 (file)
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -16,11 +16,11 @@ module BrowseHelper
       locale = available_locales.preferred(preferred_languages)
 
       if object.tags.include? "name:#{locale}"
-        name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["name:#{locale}"].to_s), :id => content_tag(:bdi, name)
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["name:#{locale}"].to_s), :id => tag.bdi(name)
       elsif object.tags.include? "name"
-        name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["name"].to_s), :id => content_tag(:bdi, name)
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["name"].to_s), :id => tag.bdi(name)
       elsif object.tags.include? "ref"
-        name = t "printable_name.with_name_html", :name => content_tag(:bdi, object.tags["ref"].to_s), :id => content_tag(:bdi, name)
+        name = t "printable_name.with_name_html", :name => tag.bdi(object.tags["ref"].to_s), :id => tag.bdi(name)
       end
     end
 

diff --git a/app/helpers/browse_tags_helper.rb b/app/helpers/browse_tags_helper.rb
index fc25325a4b0bf07472d2a2a824608901843650b7..5acbba9c7eaeed49df17baa9af3f3f5e2fe38ea9 100644 (file)
--- a/app/helpers/browse_tags_helper.rb
+++ b/app/helpers/browse_tags_helper.rb
@@ -30,7 +30,7 @@ module BrowseTagsHelper
       end
       safe_join(phones, "; ")
     elsif colour_value = colour_preview(key, value)
-      content_tag(:span, "", :class => "colour-preview-box", :"data-colour" => colour_value, :title => t("browse.tag_details.colour_preview", :colour_value => colour_value)) + colour_value
+      tag.span("", :class => "colour-preview-box", :"data-colour" => colour_value, :title => t("browse.tag_details.colour_preview", :colour_value => colour_value)) + colour_value
     else
       linkify h(value)
     end

diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb
index 43ca98c9134c5e13d1547570da74867c2dc42d45..e6c1adb16437ce2cefe33722155028b7d8f1c903 100644 (file)
--- a/app/helpers/issues_helper.rb
+++ b/app/helpers/issues_helper.rb
@@ -28,9 +28,9 @@ module IssuesHelper
   def open_issues_count
     count = Issue.visible_to(current_user).open.limit(100).size
     if count > 99
-      content_tag(:span, "99+", :class => "count-number")
+      tag.span("99+", :class => "count-number")
     elsif count.positive?
-      content_tag(:span, count, :class => "count-number")
+      tag.span(count, :class => "count-number")
     end
   end
 end

diff --git a/app/helpers/notifier_helper.rb b/app/helpers/notifier_helper.rb
index cc99898aa7b78ebe8e8121aec7e3aceaa86979bf..c18f79903ab52d2155a0a4550f6f1b4742461e05 100644 (file)
--- a/app/helpers/notifier_helper.rb
+++ b/app/helpers/notifier_helper.rb
@@ -5,8 +5,7 @@ module NotifierHelper
 
   def link_to_user(display_name)
     link_to(
-      content_tag(
-        "strong",
+      tag.strong(
         display_name,
         # NB we need "text-decoration: none" twice: GMail only honours it on
         # the <a> but Outlook only on the <strong>

diff --git a/app/helpers/user_roles_helper.rb b/app/helpers/user_roles_helper.rb
index b9430535ea3fa8702b5cbee8b3e77a7acb624c14..43807659243f47f1ddf6c8d91eccfb43701cb192 100644 (file)
--- a/app/helpers/user_roles_helper.rb
+++ b/app/helpers/user_roles_helper.rb
@@ -29,7 +29,7 @@ module UserRolesHelper
     if image
       svg_icon = tag("source", :srcset => image_path("#{image}.svg"), :type => "image/svg+xml")
       png_icon = image_tag("#{image}.png", :srcset => image_path("#{image}.svg"), :size => "20x20", :border => 0, :alt => alt, :title => title)
-      icon = content_tag("picture", svg_icon + png_icon)
+      icon = tag.picture(svg_icon + png_icon)
       icon = link_to(icon, url, :method => :post, :confirm => confirm) if url
     end
 

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 14c5f8231d56b95761cea9010cdb434230974e5e..c0707728ee329bd17e19e1caba98980e085561d1 100644 (file)
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -32,7 +32,7 @@
 
 class Issue < ApplicationRecord
   belongs_to :reportable, :polymorphic => true
-  belongs_to :reported_user, :class_name => "User", :foreign_key => :reported_user_id
+  belongs_to :reported_user, :class_name => "User"
   belongs_to :user_resolved, :class_name => "User", :foreign_key => :resolved_by
   belongs_to :user_updated, :class_name => "User", :foreign_key => :updated_by
 

diff --git a/app/models/note_comment.rb b/app/models/note_comment.rb
index 9611cfe3af375861b865ec17582b0d278fae6c1f..eed917eee3c868d2bf6ec19deb258c4481bc54f7 100644 (file)
--- a/app/models/note_comment.rb
+++ b/app/models/note_comment.rb
@@ -24,8 +24,8 @@
 #
 
 class NoteComment < ApplicationRecord
-  belongs_to :note, :foreign_key => :note_id, :touch => true
-  belongs_to :author, :class_name => "User", :foreign_key => :author_id
+  belongs_to :note, :touch => true
+  belongs_to :author, :class_name => "User"
 
   validates :id, :uniqueness => true, :presence => { :on => :update },
                  :numericality => { :on => :update, :only_integer => true }

diff --git a/app/models/relation_member.rb b/app/models/relation_member.rb
index 7f07dda9b82987226086f7d054e0a568d922f756..2de551c3f437c2b420574ca84aa58e17f9421bf3 100644 (file)
--- a/app/models/relation_member.rb
+++ b/app/models/relation_member.rb
@@ -21,6 +21,6 @@ class RelationMember < ApplicationRecord
   self.table_name = "current_relation_members"
   self.primary_keys = "relation_id", "sequence_id"
 
-  belongs_to :relation, :foreign_key => :relation_id
+  belongs_to :relation
   belongs_to :member, :polymorphic => true
 end

diff --git a/app/models/user_block.rb b/app/models/user_block.rb
index 9150bae7962b641c03e49ee7ddd888b0d57d4756..47ff9ff08abcb4359476f830da79fa714b2d344c 100644 (file)
--- a/app/models/user_block.rb
+++ b/app/models/user_block.rb
@@ -28,9 +28,9 @@ class UserBlock < ApplicationRecord
   validate :moderator_permissions
   validates :reason, :characters => true
 
-  belongs_to :user, :class_name => "User", :foreign_key => :user_id
-  belongs_to :creator, :class_name => "User", :foreign_key => :creator_id
-  belongs_to :revoker, :class_name => "User", :foreign_key => :revoker_id
+  belongs_to :user, :class_name => "User"
+  belongs_to :creator, :class_name => "User"
+  belongs_to :revoker, :class_name => "User"
 
   PERIODS = Settings.user_block_periods