Add rubocop-factory_bot and fix warnings

diff --git a/.rubocop.yml b/.rubocop.yml
index cfa31cc048d6423973cd42b78d6ad7d000a63c1b..051b7a6a7aaec1638821d5d39d6e11b235d1aca2 100644 (file)
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -2,6 +2,7 @@ inherit_from: .rubocop_todo.yml
 
 require:
   - rubocop-capybara
 
 require:
   - rubocop-capybara

+  - rubocop-factory_bot

   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails
   - rubocop-minitest
   - rubocop-performance
   - rubocop-rails

diff --git a/Gemfile b/Gemfile
index c25240f9ff0623f547dfc17f46942484e27b7efe..39ffed86006555c094fa52d6c77394b1bfd9a8a1 100644 (file)
--- a/Gemfile
+++ b/Gemfile
@@ -153,6 +153,7 @@ group :test do
   gem "rails-controller-testing"
   gem "rubocop"
   gem "rubocop-capybara"
   gem "rails-controller-testing"
   gem "rubocop"
   gem "rubocop-capybara"

+  gem "rubocop-factory_bot"

   gem "rubocop-minitest"
   gem "rubocop-performance"
   gem "rubocop-rails"
   gem "rubocop-minitest"
   gem "rubocop-performance"
   gem "rubocop-rails"

diff --git a/Gemfile.lock b/Gemfile.lock
index 4c0b25147a7f32eb48de78d6d91b5bb7a55a9170..0927586ab21f02f52131ddfb60ad7d01c1fd1b59 100644 (file)
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -444,6 +444,8 @@ GEM
       parser (>= 3.2.1.0)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
       parser (>= 3.2.1.0)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)

+    rubocop-factory_bot (2.23.1)
+      rubocop (~> 1.33)

     rubocop-minitest (0.31.0)
       rubocop (>= 1.39, < 2.0)
     rubocop-performance (1.17.1)
     rubocop-minitest (0.31.0)
       rubocop (>= 1.39, < 2.0)
     rubocop-performance (1.17.1)


@@ -603,6 +605,7 @@ DEPENDENCIES
   rotp
   rubocop
   rubocop-capybara
   rotp
   rubocop
   rubocop-capybara

+  rubocop-factory_bot

   rubocop-minitest
   rubocop-performance
   rubocop-rails
   rubocop-minitest
   rubocop-performance
   rubocop-rails

diff --git a/test/controllers/browse_controller_test.rb b/test/controllers/browse_controller_test.rb
index 578e78fa25d8e533b517f707e3a43f2d5cd27118..674a318ed9173fd6e9a0cf0df149c1075d316fb9 100644 (file)
--- a/test/controllers/browse_controller_test.rb
+++ b/test/controllers/browse_controller_test.rb
@@ -55,13 +55,13 @@ class BrowseControllerTest < ActionDispatch::IntegrationTest
   end
 
   def test_read_node
   end
 
   def test_read_node

-    node = create :node
+    node = create(:node)

     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 1
   end
 
   def test_read_deleted_node
     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 1
   end
 
   def test_read_deleted_node

-    node = create :node, :visible => false
+    node = create(:node, :visible => false)

     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 0
   end
     browse_check :node_path, node.id, "browse/feature"
     assert_select "a[href='#{api_node_path node}']", :count => 0
   end