]> git.openstreetmap.org Git - rails.git/commitdiff
Quote ruby versions in yaml
authorAndy Allan <git@gravitystorm.co.uk>
Wed, 28 Dec 2022 10:01:37 +0000 (10:01 +0000)
committerAndy Allan <git@gravitystorm.co.uk>
Wed, 28 Dec 2022 10:04:32 +0000 (10:04 +0000)
Without quotes these are parsed as numbers, which can cause subtle
problems. For example, "ruby: 3.0" is interpreted by the
ruby/setup-rubyaction as "ruby: 3", meaning 3.x instead of the
intended 3.0.x

.github/workflows/lint.yml
.github/workflows/tests.yml

index 94eb05df947fe93486042d95729a88bfe437e856..bd02bd6240d8f5ff9543f2854f6304b5af5cfc13 100644 (file)
@@ -7,7 +7,7 @@ concurrency:
   cancel-in-progress: true
 env:
   os: ubuntu-20.04
-  ruby: 2.7
+  ruby: '2.7'
 jobs:
   rubocop:
     name: RuboCop
index 73ce90b9272239d132db2d7cf6f21ed01e288224..f01b44bb7f264da842df7c5910fef0a5bec57369 100644 (file)
@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         ubuntu: [20.04, 22.04]
-        ruby: [2.7, 3.0, 3.1]
+        ruby: ['2.7', '3.0', '3.1']
     runs-on: ubuntu-${{ matrix.ubuntu }}
     env:
       RAILS_ENV: test