Remove some (hopefully) redundant code

diff --git a/app/models/old_node.rb b/app/models/old_node.rb
index 90304acae4c1f9dadbaceaecc37475703648cbdd..5ea3a778b38d58e5eefc62da019f7e628d5bd4b0 100644 (file)
--- a/app/models/old_node.rb
+++ b/app/models/old_node.rb
@@ -63,11 +63,6 @@ class OldNode < ActiveRecord::Base
 
   def save_with_dependencies!
     save!
 
   def save_with_dependencies!
     save!

-    #not sure whats going on here
-    clear_aggregation_cache
-    clear_association_cache
-    #ok from here
-    @attributes.update(OldNode.where(:node_id => self.node_id, :timestamp => self.timestamp, :version => self.version).first.instance_variable_get('@attributes'))

    
     self.tags.each do |k,v|
       tag = OldNodeTag.new
    
     self.tags.each do |k,v|
       tag = OldNodeTag.new

diff --git a/app/models/old_relation.rb b/app/models/old_relation.rb
index dc89afa50294ba35710123aa382243676f04c282..5496f7115ad717491a8a292bade768522ed3fcb0 100644 (file)
--- a/app/models/old_relation.rb
+++ b/app/models/old_relation.rb
@@ -31,14 +31,7 @@ class OldRelation < ActiveRecord::Base
   end
 
   def save_with_dependencies!
   end
 
   def save_with_dependencies!

-
-    # see comment in old_way.rb ;-)

     save!
     save!

-    clear_aggregation_cache
-    clear_association_cache
-    @attributes.update(OldRelation.where(:relation_id => self.relation_id, :timestamp => self.timestamp).order("version DESC").first.instance_variable_get('@attributes'))
-
-    # ok, you can touch from here on

 
     self.tags.each do |k,v|
       tag = OldRelationTag.new
 
     self.tags.each do |k,v|
       tag = OldRelationTag.new

diff --git a/app/models/old_way.rb b/app/models/old_way.rb
index 1552bae0497a10f0b8c5d896ff11d83251bdbf7a..dbdcdd46d62dbaf2f0f591b29681c76d3af4f71a 100644 (file)
--- a/app/models/old_way.rb
+++ b/app/models/old_way.rb
@@ -31,19 +31,7 @@ class OldWay < ActiveRecord::Base
   end
 
   def save_with_dependencies!
   end
 
   def save_with_dependencies!

-
-    # dont touch this unless you really have figured out why it's called
-    # (Rails doesn't deal well with the old ways table (called 'ways') because
-    # it doesn't have a unique key. It knows how to insert and auto_increment
-    # id and get it back but we have that and we want to get the 'version' back
-    # we could add another column but thats a lot of data. No, set_primary_key
-    # doesn't work either.

     save!
     save!

-    clear_aggregation_cache
-    clear_association_cache
-    @attributes.update(OldWay.where(:way_id => self.way_id, :timestamp => self.timestamp).order("version DESC").first.instance_variable_get('@attributes'))
-
-    # ok, you can touch from here on

 
     self.tags.each do |k,v|
       tag = OldWayTag.new
 
     self.tags.each do |k,v|
       tag = OldWayTag.new