Link to wikipedia articles on wikipedia=* tags

The semantics are as documented on
http://wiki.openstreetmap.org/wiki/Key:wikipedia, i.e.:

    # English Wikipedia article Foobar
    wikipedia=Foobar
    # German Wikipedia article Foobar
    wikipedia:de=Foobar
    wikipedia=de:Foobar

If someone gives a http:// link we just pass it through.

diff --git a/app/helpers/browse_helper.rb b/app/helpers/browse_helper.rb
index 1d0b02df03e88229b7b86b72bb626c04d4ae0357..07dd866ba831f4ef10e4708a72184990a2ba880d 100644 (file)
--- a/app/helpers/browse_helper.rb
+++ b/app/helpers/browse_helper.rb
@@ -25,7 +25,9 @@ module BrowseHelper
   end
 
   def format_value(key, value)
-    if url = wiki_link("tag", "#{key}=#{value}")
+    if wp = wikipedia_link(key, value)
+      link_to h(wp['title']), wp['url'], :title => t('browse.tag_details.wiki_link.wikipedia', :page => wp['title'])
+    elsif url = wiki_link("tag", "#{key}=#{value}")
       link_to h(value), url, :title => t('browse.tag_details.wiki_link.tag', :key => key, :value => value)
     else
       linkify h(value)
@@ -45,4 +47,34 @@ private
 
     return url
   end
+
+  def wikipedia_link(key, value)
+    # English Wikipedia by default
+    lang = 'en'
+
+    if key == 'wikipedia' or key =~ /^wikipedia:(\S+)$/
+      mylang = $1
+
+      # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
+      return nil if value =~ /^http:\/\//
+
+      if mylang
+        lang = mylang
+      # This regex should match Wikipedia language codes, everything
+      # from de to zh-classical
+      elsif value =~ /^([a-z-]{2,12}):(.+)$/
+        lang  = $1
+        # Don't display e.g. "en:Foobar" as the title, just "Foobar"
+        value = $2
+      end
+
+      locale = I18n.locale.to_s
+      return {
+        'url' => "http://#{lang}.wikipedia.org/wiki/#{value}?uselang=#{locale}",
+        'title' => value
+      }
+    else
+      return nil
+    end
+  end
 end

diff --git a/config/locales/en.yml b/config/locales/en.yml
index 7b9720fbdcbb1c469b7e6ac742d5b303dfd69384..4883b9b07f63777328aaa195a5ce9ed697d456c6 100644 (file)
--- a/config/locales/en.yml
+++ b/config/locales/en.yml
@@ -236,6 +236,7 @@ en:
       wiki_link:
         key: "The wiki description page for the {{key}} tag"
         tag: "The wiki description page for the {{key}}={{value}} tag"
+        wikipedia: "The {{page}} article on Wikipedia"
     way_details:
       nodes: "Nodes:"
       part_of: "Part of:"