Reimplement User#is_friends_with? in a non-insane way

diff --git a/app/models/user.rb b/app/models/user.rb
index ef0dcc4b0f150a9f5c99942b8a819938e07b24e7..2e312119f8d13e669e7b941890b65932d18ca837 100644 (file)
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -142,14 +142,7 @@ class User < ActiveRecord::Base
   end
 
   def is_friends_with?(new_friend)
   end
 
   def is_friends_with?(new_friend)

-    res = false
-    @new_friend = new_friend
-    self.friends.each do |friend|
-      if friend.friend_user_id == @new_friend.id
-        return true
-      end
-    end
-    return false
+    self.friends.where(:friend_user_id => new_friend.id).exists?

   end
 
   ##
   end
 
   ##