some boolean correctness work

diff --git a/app/controllers/message_controller.rb b/app/controllers/message_controller.rb
index f3f3bf9ea13404e177e23a605a2ba42a32928bd4..fc7a9101b12496084b96c054db873013874dbea3 100644 (file)
--- a/app/controllers/message_controller.rb
+++ b/app/controllers/message_controller.rb
@@ -40,7 +40,7 @@ class MessageController < ApplicationController
   def read
     @title = 'read message'
     @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])
   def read
     @title = 'read message'
     @message = Message.find(params[:message_id], :conditions => ["to_user_id = ? or from_user_id = ?", @user.id, @user.id ])

-    @message.message_read = 1 if @message.to_user_id == @user.id
+    @message.message_read = true if @message.to_user_id == @user.id

     @message.save
   rescue ActiveRecord::RecordNotFound
     render :nothing => true, :status => :not_found
     @message.save
   rescue ActiveRecord::RecordNotFound
     render :nothing => true, :status => :not_found


@@ -70,10 +70,10 @@ class MessageController < ApplicationController
       id = params[:message_id]
       message = Message.find_by_id(id)
       if params[:mark] == 'unread'
       id = params[:message_id]
       message = Message.find_by_id(id)
       if params[:mark] == 'unread'

-        message_read = 0 
+        message_read = false 

         mark_type = 'unread'
       else
         mark_type = 'unread'
       else

-        message_read = 1
+        message_read = true

         mark_type = 'read'
       end
       message.message_read = message_read
         mark_type = 'read'
       end
       message.message_read = message_read

diff --git a/app/models/node.rb b/app/models/node.rb
index 4ee8498385ca4d9bc1a48aaa6cf0dd64b60ad53d..3481e28ca4d2dfeb67ebde20100d6f7a26f76b44 100644 (file)
--- a/app/models/node.rb
+++ b/app/models/node.rb
@@ -156,7 +156,7 @@ class Node < ActiveRecord::Base
         raise OSM::APIPreconditionFailedError.new
       else
         self.changeset_id = new_node.changeset_id
         raise OSM::APIPreconditionFailedError.new
       else
         self.changeset_id = new_node.changeset_id

-        self.visible = 0
+        self.visible = false

 
         # update the changeset with the deleted position
         changeset.update_bbox!(bbox)
 
         # update the changeset with the deleted position
         changeset.update_bbox!(bbox)