Thomas Wood [Fri, 23 Jan 2009 19:14:21 +0000 (19:14 +0000)]
Set params to sane defaults if unset by client.
Reject creates with no file with 400, model validations will also reject with 400 (as was existing but broken behaviour)
Closes #1510
Thomas Wood [Fri, 23 Jan 2009 01:19:45 +0000 (01:19 +0000)]
Require auth on calls to /trace/create, and pass through to form if called without params. Adjust validations on traces to prevent dual error messages on description (validates_presence_of catches the empty string removed from length validation)
More changes to come for api_create
References #1510
Matt Amos [Tue, 23 Dec 2008 15:59:56 +0000 (15:59 +0000)]
removed comments which apparently no-one bothers to read anyway. since no-one reads the comments, changed changeset model to use Time instead of DateTime. will probably have to change it back later, when someone else who doesn't read comments comes along.
Shaun McDonald [Mon, 15 Dec 2008 19:20:24 +0000 (19:20 +0000)]
Fix the transactions, need to set anything that will be returned to nil outside the transaction, otherwise it won't be available after the end of the transaction, when it is returned.
Shaun McDonald [Fri, 12 Dec 2008 19:04:28 +0000 (19:04 +0000)]
Log the request on a few requests when there is a bad request, probably should do this in a few more places. This makes it easier to see why we are getting errors/bad requests.
Shaun McDonald [Tue, 9 Dec 2008 18:44:11 +0000 (18:44 +0000)]
Some improvements for the XML parsing, as there are somethings that we don't need, like timestamp and visibility, thus hopefully bringing a speedup in the xml parsing. Some more AMF controller fixes, plenty more to go though.
Shaun McDonald [Mon, 8 Dec 2008 15:30:19 +0000 (15:30 +0000)]
Adding the ability to see the min/max lat/lon for a changeset in the data browser. Adding file for the nice message that should show when a user is missing in the message controller.
Shaun McDonald [Thu, 4 Dec 2008 17:30:17 +0000 (17:30 +0000)]
Refactoring the amf controller, and all models so that save_with_history! is now private. Everyone should use create_with_history, delete_with_history, and update_from instead. Also gets the amf controller to do version checks in the node/way/relation models. Needs checked. This breaks Potlatch until #1376 is fixed.
Shaun McDonald [Wed, 3 Dec 2008 12:56:02 +0000 (12:56 +0000)]
Deal with active record not found exceptions when creating message. Some tidying of html. For some reason in rails 2.1.2 having a comment at the end of a line, in the view, means that the closing tag needs to be on the next line.
Shaun McDonald [Thu, 27 Nov 2008 17:06:43 +0000 (17:06 +0000)]
Adding pagination to the changesets, thus allowing you to browe large changesets, without MySQL complaining about memory. Probably needs some fine tuning. You currently can only page one of nodes, ways, and relations, without manually setting the relations. Fixing deprection notice for the classic_pagination plugin.
Shaun McDonald [Mon, 24 Nov 2008 18:55:24 +0000 (18:55 +0000)]
Make the role in relations optional, with a test to make sure it is. Also start moving the errors reading the xml to exceptions, thus making it possible to give meaningful error messages, when bad xml is sent (More work is required on this including doing the same for nodes and ways). With the latest gems update it seems that the lib xml handling was broken, using the newer method. Adding the content type for the exceptions.
Shaun McDonald [Thu, 20 Nov 2008 21:23:44 +0000 (21:23 +0000)]
Closes #1350 through updating amf_controller to use the newer closed_at method of determining whether a changeset is closed. Richard please check the rest of the amf controller for more things that may reference the open field that is no longer available. Use is_open? to determine if a changeset is open. Fix indentation in amf controller. Fix minor bug in the links to changesets in the data brower.
Shaun McDonald [Mon, 17 Nov 2008 19:11:54 +0000 (19:11 +0000)]
Make the dates and times that the server deals with UTC. This is probably required for changeset, as they could auto close instantly when the clocks go forward by one hour.
Matt Amos [Mon, 17 Nov 2008 19:00:01 +0000 (19:00 +0000)]
Migration to add close-time to changesets. This replaces the boolean 'open' attribute. Added checks to ensure that the maximum lifetime and number of changes in a changeset are enforced. Added some tests.