]> git.openstreetmap.org Git - rails.git/log
rails.git
5 months agoUrl-encode wikimedia_commons tag values
Anton Khorev [Thu, 20 Jun 2024 19:13:28 +0000 (22:13 +0300)]
Url-encode wikimedia_commons tag values

5 months agoMerge remote-tracking branch 'upstream/pull/4913'
Tom Hughes [Wed, 19 Jun 2024 19:41:20 +0000 (20:41 +0100)]
Merge remote-tracking branch 'upstream/pull/4913'

5 months agoDisable Rails/BulkChangeTable cop
Andy Allan [Wed, 19 Jun 2024 16:44:20 +0000 (17:44 +0100)]
Disable Rails/BulkChangeTable cop

If you have multiple alter commands in a migration (like adding two
columns to an existing table) this cop will suggest combining them using
`change_table :foo, :bulk => true`.

However, Strong Migrations can't inspect `change_table` blocks, and
therefore suggests using `safety_assured`, which mostly defeats the
purpose of using strong_migrations in the first place.

Instead, we should stick with the individual alter commands. Since
postgres runs DDL changes in a transaction anyway, there is not enough
benefit from the `change_table` approach to be worth losing the
safety net of the Strong Migrations checks.

5 months agoMerge pull request #4813 from AntonKhorev/no-fst-italic
Andy Allan [Wed, 19 Jun 2024 14:34:14 +0000 (15:34 +0100)]
Merge pull request #4813 from AntonKhorev/no-fst-italic

Use font size instead of italic for changeset/trace descriptions

5 months agoMerge pull request #4884 from AntonKhorev/copyright-page-title
Andy Allan [Wed, 19 Jun 2024 14:26:21 +0000 (15:26 +0100)]
Merge pull request #4884 from AntonKhorev/copyright-page-title

Add title to copyright page

5 months agoMerge remote-tracking branch 'upstream/pull/4911'
Tom Hughes [Wed, 19 Jun 2024 14:17:24 +0000 (15:17 +0100)]
Merge remote-tracking branch 'upstream/pull/4911'

5 months agoAdd Anton as a maintainer
Andy Allan [Wed, 19 Jun 2024 14:02:51 +0000 (15:02 +0100)]
Add Anton as a maintainer

5 months agoMerge pull request #4887 from AntonKhorev/full-encode-wikipedia-value
Andy Allan [Wed, 19 Jun 2024 13:41:38 +0000 (14:41 +0100)]
Merge pull request #4887 from AntonKhorev/full-encode-wikipedia-value

Fully encode wikipedia tag values

5 months agoMerge pull request #4909 from matkoniecz/patch-1
Andy Allan [Wed, 19 Jun 2024 12:54:22 +0000 (13:54 +0100)]
Merge pull request #4909 from matkoniecz/patch-1

start STOTMEU banner now

5 months agostart STOTMEU banner now
Mateusz Konieczny [Wed, 19 Jun 2024 10:34:36 +0000 (12:34 +0200)]
start STOTMEU banner now

note that start date was mandatory in initial per https://github.com/openstreetmap/openstreetmap-website/blob/master/FAQ.md#how-do-i-create-a-banner-to-promote-my-openstreetmap-event

> The pull request must indicate when the banner should start being shown, which must be at least 7 days after the pull request was created.

5 months agoMerge pull request #4906 from matkoniecz/sotmeu-banner
Andy Allan [Wed, 19 Jun 2024 09:32:49 +0000 (10:32 +0100)]
Merge pull request #4906 from matkoniecz/sotmeu-banner

SOTMEU 2024 banner

5 months agoMerge pull request #4908 from tomhughes/changeset-size-limit
Andy Allan [Wed, 19 Jun 2024 09:01:23 +0000 (10:01 +0100)]
Merge pull request #4908 from tomhughes/changeset-size-limit

Add the ability to limit changeset size

5 months agoAdd tests for API changeset size limits
Tom Hughes [Tue, 18 Jun 2024 23:41:30 +0000 (00:41 +0100)]
Add tests for API changeset size limits

5 months agoUpdate tests to avoid triggering changeset size limits
Tom Hughes [Tue, 18 Jun 2024 21:45:01 +0000 (22:45 +0100)]
Update tests to avoid triggering changeset size limits

5 months agoEnforce changeset size limit for API calls which make changes
Tom Hughes [Tue, 18 Jun 2024 19:45:00 +0000 (20:45 +0100)]
Enforce changeset size limit for API calls which make changes

5 months agoAdd support for per-user limits on the size of changes that can be made
Tom Hughes [Tue, 18 Jun 2024 19:35:09 +0000 (20:35 +0100)]
Add support for per-user limits on the size of changes that can be made

5 months agoUpdate bundle
Tom Hughes [Tue, 18 Jun 2024 17:15:41 +0000 (18:15 +0100)]
Update bundle

5 months agoMerge remote-tracking branch 'upstream/pull/4891'
Tom Hughes [Mon, 17 Jun 2024 16:22:38 +0000 (17:22 +0100)]
Merge remote-tracking branch 'upstream/pull/4891'

5 months agoMerge remote-tracking branch 'upstream/pull/4905'
Tom Hughes [Mon, 17 Jun 2024 16:15:16 +0000 (17:15 +0100)]
Merge remote-tracking branch 'upstream/pull/4905'

5 months agoMove diary comments hide/unhide actions to comments controller
Anton Khorev [Mon, 17 Jun 2024 15:10:32 +0000 (18:10 +0300)]
Move diary comments hide/unhide actions to comments controller

5 months agoSOTMEU 2024 banner
Mateusz Konieczny [Mon, 17 Jun 2024 13:38:26 +0000 (15:38 +0200)]
SOTMEU 2024 banner

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 17 Jun 2024 12:16:52 +0000 (14:16 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoMerge remote-tracking branch 'upstream/pull/4902'
Tom Hughes [Sun, 16 Jun 2024 17:53:00 +0000 (18:53 +0100)]
Merge remote-tracking branch 'upstream/pull/4902'

5 months agoMerge remote-tracking branch 'upstream/pull/4899'
Tom Hughes [Sun, 16 Jun 2024 17:50:05 +0000 (18:50 +0100)]
Merge remote-tracking branch 'upstream/pull/4899'

5 months agoIntroduce geocode event callback for route endpoints
Anton Khorev [Sat, 15 Jun 2024 19:04:15 +0000 (22:04 +0300)]
Introduce geocode event callback for route endpoints

Removes remaining getRoute() call from endpoint objects.

5 months agoIntroduce drag event callback for route endpoints
Anton Khorev [Sat, 15 Jun 2024 18:51:48 +0000 (21:51 +0300)]
Introduce drag event callback for route endpoints

Avoids calling getRoute() from within endpoint objects.

5 months agoUse default og:image if Addressable::URI fails
Anton Khorev [Sat, 15 Jun 2024 12:57:10 +0000 (15:57 +0300)]
Use default og:image if Addressable::URI fails

5 months agoJoin and normalize og:image url using Addressable
Anton Khorev [Sat, 15 Jun 2024 12:03:22 +0000 (15:03 +0300)]
Join and normalize og:image url using Addressable

Avoids failing on urls that are not strictly rfc2396 URIs.

5 months agoBump eslint from 9.4.0 to 9.5.0
dependabot[bot] [Fri, 14 Jun 2024 23:12:34 +0000 (23:12 +0000)]
Bump eslint from 9.4.0 to 9.5.0

Bumps [eslint](https://github.com/eslint/eslint) from 9.4.0 to 9.5.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.4.0...v9.5.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
5 months agoMerge remote-tracking branch 'upstream/pull/4897'
Tom Hughes [Fri, 14 Jun 2024 17:02:50 +0000 (18:02 +0100)]
Merge remote-tracking branch 'upstream/pull/4897'

5 months agoMerge remote-tracking branch 'upstream/pull/4896'
Tom Hughes [Fri, 14 Jun 2024 17:02:11 +0000 (18:02 +0100)]
Merge remote-tracking branch 'upstream/pull/4896'

5 months agoUse .is-invalid to highlight routing inputs with failed geocode lookups
Anton Khorev [Fri, 14 Jun 2024 16:42:45 +0000 (19:42 +0300)]
Use .is-invalid to highlight routing inputs with failed geocode lookups

5 months agoRemove global "awaiting geocode" routing state
Anton Khorev [Fri, 14 Jun 2024 16:14:49 +0000 (19:14 +0300)]
Remove global "awaiting geocode" routing state

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 13 Jun 2024 12:16:53 +0000 (14:16 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoMerge remote-tracking branch 'upstream/pull/4892'
Tom Hughes [Wed, 12 Jun 2024 17:58:28 +0000 (18:58 +0100)]
Merge remote-tracking branch 'upstream/pull/4892'

5 months agoShow u-turn icons for GraphHopper u-turn instructions
Anton Khorev [Wed, 12 Jun 2024 14:34:41 +0000 (17:34 +0300)]
Show u-turn icons for GraphHopper u-turn instructions

5 months agoShow fork icons for GraphHopper keep right/left instructions
Anton Khorev [Wed, 12 Jun 2024 14:31:02 +0000 (17:31 +0300)]
Show fork icons for GraphHopper keep right/left instructions

5 months agoMerge remote-tracking branch 'upstream/pull/4889'
Tom Hughes [Tue, 11 Jun 2024 16:59:58 +0000 (17:59 +0100)]
Merge remote-tracking branch 'upstream/pull/4889'

5 months agoUpdate bundle
Tom Hughes [Tue, 11 Jun 2024 16:36:42 +0000 (17:36 +0100)]
Update bundle

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Tue, 11 Jun 2024 10:47:19 +0000 (12:47 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Tue, 11 Jun 2024 09:42:49 +0000 (11:42 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoMove diary comments index action to comments controller
Anton Khorev [Mon, 10 Jun 2024 13:09:07 +0000 (16:09 +0300)]
Move diary comments index action to comments controller

5 months agoMerge remote-tracking branch 'upstream/pull/4883'
Tom Hughes [Sun, 9 Jun 2024 14:37:17 +0000 (15:37 +0100)]
Merge remote-tracking branch 'upstream/pull/4883'

5 months agoDrop dummy classes that are unneeded and don't work
Tom Hughes [Sun, 9 Jun 2024 13:54:29 +0000 (14:54 +0100)]
Drop dummy classes that are unneeded and don't work

5 months agoMerge remote-tracking branch 'upstream/pull/4875'
Tom Hughes [Sun, 9 Jun 2024 13:42:50 +0000 (14:42 +0100)]
Merge remote-tracking branch 'upstream/pull/4875'

5 months agoMerge remote-tracking branch 'upstream/pull/4888'
Tom Hughes [Sun, 9 Jun 2024 10:52:56 +0000 (11:52 +0100)]
Merge remote-tracking branch 'upstream/pull/4888'

5 months agoMerge remote-tracking branch 'upstream/pull/4886'
Tom Hughes [Sun, 9 Jun 2024 10:43:27 +0000 (11:43 +0100)]
Merge remote-tracking branch 'upstream/pull/4886'

5 months agoMerge remote-tracking branch 'upstream/pull/4885'
Tom Hughes [Sun, 9 Jun 2024 10:40:44 +0000 (11:40 +0100)]
Merge remote-tracking branch 'upstream/pull/4885'

5 months agoRedraw routing sprites
Anton Khorev [Thu, 16 May 2024 23:00:33 +0000 (02:00 +0300)]
Redraw routing sprites

5 months agoFully encode wikipedia tag values
Anton Khorev [Sat, 8 Jun 2024 12:59:30 +0000 (15:59 +0300)]
Fully encode wikipedia tag values

5 months agoAdd note and diary comments counts to the user profile
Nenad Vujicic [Mon, 3 Jun 2024 12:58:23 +0000 (14:58 +0200)]
Add note and diary comments counts to the user profile

Fixes #1643

5 months agoDon't set width of richtext preview
Anton Khorev [Fri, 7 Jun 2024 15:00:09 +0000 (18:00 +0300)]
Don't set width of richtext preview

5 months agoRemove unused map link locale strings
Anton Khorev [Fri, 7 Jun 2024 10:15:42 +0000 (13:15 +0300)]
Remove unused map link locale strings

5 months agoAdd title to copyright page
Anton Khorev [Fri, 7 Jun 2024 09:51:38 +0000 (12:51 +0300)]
Add title to copyright page

5 months agoDon't add site name to og:title when page title is provided
Anton Khorev [Fri, 7 Jun 2024 08:33:00 +0000 (11:33 +0300)]
Don't add site name to og:title when page title is provided

5 months agoMerge remote-tracking branch 'upstream/pull/4882'
Tom Hughes [Thu, 6 Jun 2024 18:09:15 +0000 (19:09 +0100)]
Merge remote-tracking branch 'upstream/pull/4882'

5 months agoMerge remote-tracking branch 'upstream/pull/4881'
Tom Hughes [Thu, 6 Jun 2024 17:35:48 +0000 (18:35 +0100)]
Merge remote-tracking branch 'upstream/pull/4881'

5 months agoAdd last edited date to user profile
Nenad Vujicic [Thu, 6 Jun 2024 12:35:31 +0000 (14:35 +0200)]
Add last edited date to user profile

Fixes #3437

5 months agoEnsure that Open Graph image url is absolute
Anton Khorev [Thu, 6 Jun 2024 15:01:23 +0000 (18:01 +0300)]
Ensure that Open Graph image url is absolute

5 months agoSet Open Graph image to first image for diary entries
Anton Khorev [Thu, 6 Jun 2024 14:28:57 +0000 (17:28 +0300)]
Set Open Graph image to first image for diary entries

5 months agoAdd image method to get first image from rich text
Anton Khorev [Thu, 6 Jun 2024 13:47:06 +0000 (16:47 +0300)]
Add image method to get first image from rich text

5 months agoMerge remote-tracking branch 'upstream/pull/4877'
Tom Hughes [Wed, 5 Jun 2024 17:37:57 +0000 (18:37 +0100)]
Merge remote-tracking branch 'upstream/pull/4877'

5 months agoMerge remote-tracking branch 'upstream/pull/4878'
Tom Hughes [Wed, 5 Jun 2024 17:36:30 +0000 (18:36 +0100)]
Merge remote-tracking branch 'upstream/pull/4878'

5 months agoMerge remote-tracking branch 'upstream/pull/4876'
Tom Hughes [Wed, 5 Jun 2024 17:34:06 +0000 (18:34 +0100)]
Merge remote-tracking branch 'upstream/pull/4876'

5 months agoUpdate to rails 7.1.3.4
Tom Hughes [Tue, 4 Jun 2024 23:06:53 +0000 (00:06 +0100)]
Update to rails 7.1.3.4

5 months agoUpdate bundle
Tom Hughes [Tue, 4 Jun 2024 16:07:19 +0000 (17:07 +0100)]
Update bundle

5 months agoMove changeset subscribe/unsubscribe locale strings out of javascripts
Anton Khorev [Tue, 4 Jun 2024 13:34:03 +0000 (16:34 +0300)]
Move changeset subscribe/unsubscribe locale strings out of javascripts

5 months agoWrite changeset subscribe/unsubscribe buttons using tag.button
Anton Khorev [Tue, 4 Jun 2024 13:28:26 +0000 (16:28 +0300)]
Write changeset subscribe/unsubscribe buttons using tag.button

5 months agoMove comment changeset locale string out of javascripts
Anton Khorev [Tue, 4 Jun 2024 13:17:20 +0000 (16:17 +0300)]
Move comment changeset locale string out of javascripts

5 months agoWrite changeset comment button using tag.button
Anton Khorev [Tue, 4 Jun 2024 13:15:18 +0000 (16:15 +0300)]
Write changeset comment button using tag.button

5 months agoMove show/hide changeset comment locale strings out of javascripts
Anton Khorev [Tue, 4 Jun 2024 13:07:25 +0000 (16:07 +0300)]
Move show/hide changeset comment locale strings out of javascripts

5 months agoFix setting "From" in directions form based on search query
Anton Khorev [Tue, 4 Jun 2024 12:49:56 +0000 (15:49 +0300)]
Fix setting "From" in directions form based on search query

5 months agoRemove Open Graph og:image:secure_url property
Anton Khorev [Tue, 4 Jun 2024 10:42:01 +0000 (13:42 +0300)]
Remove Open Graph og:image:secure_url property

5 months agoMerge remote-tracking branch 'upstream/pull/4871'
Tom Hughes [Tue, 4 Jun 2024 09:38:20 +0000 (10:38 +0100)]
Merge remote-tracking branch 'upstream/pull/4871'

5 months agoMerge remote-tracking branch 'upstream/pull/4873'
Tom Hughes [Mon, 3 Jun 2024 19:26:13 +0000 (20:26 +0100)]
Merge remote-tracking branch 'upstream/pull/4873'

5 months agoMerge remote-tracking branch 'upstream/pull/4870'
Tom Hughes [Mon, 3 Jun 2024 19:14:55 +0000 (20:14 +0100)]
Merge remote-tracking branch 'upstream/pull/4870'

5 months agoRemove .btn-sm from changeset comment button
Anton Khorev [Mon, 3 Jun 2024 15:17:22 +0000 (18:17 +0300)]
Remove .btn-sm from changeset comment button

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Mon, 3 Jun 2024 12:17:15 +0000 (14:17 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoUse button elements that allow word wrap for note controls
Anton Khorev [Mon, 3 Jun 2024 10:40:11 +0000 (13:40 +0300)]
Use button elements that allow word wrap for note controls

5 months agoDecrease bottom padding of search form
Anton Khorev [Mon, 3 Jun 2024 09:29:34 +0000 (12:29 +0300)]
Decrease bottom padding of search form

5 months agoUse flex in routing form for vertical gaps
Anton Khorev [Mon, 3 Jun 2024 09:26:57 +0000 (12:26 +0300)]
Use flex in routing form for vertical gaps

5 months agoUse flex in routing form to fix marker column width
Anton Khorev [Mon, 3 Jun 2024 09:21:11 +0000 (12:21 +0300)]
Use flex in routing form to fix marker column width

5 months agoIncrease font size in directions controls
Anton Khorev [Mon, 3 Jun 2024 08:59:18 +0000 (11:59 +0300)]
Increase font size in directions controls

5 months agoMerge remote-tracking branch 'upstream/pull/4864'
Tom Hughes [Sun, 2 Jun 2024 10:19:16 +0000 (11:19 +0100)]
Merge remote-tracking branch 'upstream/pull/4864'

5 months agoMerge remote-tracking branch 'upstream/pull/4868'
Tom Hughes [Sun, 2 Jun 2024 09:54:37 +0000 (10:54 +0100)]
Merge remote-tracking branch 'upstream/pull/4868'

5 months agoMerge remote-tracking branch 'upstream/pull/4867'
Tom Hughes [Sun, 2 Jun 2024 09:52:43 +0000 (10:52 +0100)]
Merge remote-tracking branch 'upstream/pull/4867'

5 months agoMerge remote-tracking branch 'upstream/pull/4866'
Tom Hughes [Sun, 2 Jun 2024 09:43:41 +0000 (10:43 +0100)]
Merge remote-tracking branch 'upstream/pull/4866'

5 months agoMerge remote-tracking branch 'upstream/pull/4863'
Tom Hughes [Sun, 2 Jun 2024 09:41:20 +0000 (10:41 +0100)]
Merge remote-tracking branch 'upstream/pull/4863'

5 months agoInline svg sprites on about page
Anton Khorev [Sat, 1 Jun 2024 08:02:16 +0000 (11:02 +0300)]
Inline svg sprites on about page

5 months agoWrite closed note controls using submit_tag
Anton Khorev [Sat, 1 Jun 2024 06:05:19 +0000 (09:05 +0300)]
Write closed note controls using submit_tag

5 months agoIncrease font size in search form
Anton Khorev [Sat, 1 Jun 2024 04:28:00 +0000 (07:28 +0300)]
Increase font size in search form

5 months agoReplace search button text with svg icon
Anton Khorev [Sat, 1 Jun 2024 03:41:10 +0000 (06:41 +0300)]
Replace search button text with svg icon

5 months agoDon't include language prefix in wikipedia links
Anton Khorev [Sat, 1 Jun 2024 01:56:57 +0000 (04:56 +0300)]
Don't include language prefix in wikipedia links

5 months agoBump eslint from 9.3.0 to 9.4.0
dependabot[bot] [Fri, 31 May 2024 23:11:33 +0000 (23:11 +0000)]
Bump eslint from 9.3.0 to 9.4.0

Bumps [eslint](https://github.com/eslint/eslint) from 9.3.0 to 9.4.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.3.0...v9.4.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
5 months agoMerge remote-tracking branch 'upstream/pull/4843'
Tom Hughes [Thu, 30 May 2024 15:33:59 +0000 (16:33 +0100)]
Merge remote-tracking branch 'upstream/pull/4843'

5 months agoMerge remote-tracking branch 'upstream/pull/4857'
Tom Hughes [Thu, 30 May 2024 15:22:38 +0000 (16:22 +0100)]
Merge remote-tracking branch 'upstream/pull/4857'

5 months agoMerge remote-tracking branch 'upstream/pull/4847'
Tom Hughes [Thu, 30 May 2024 15:20:54 +0000 (16:20 +0100)]
Merge remote-tracking branch 'upstream/pull/4847'

5 months agoLocalisation updates from https://translatewiki.net.
translatewiki.net [Thu, 30 May 2024 12:23:28 +0000 (14:23 +0200)]
Localisation updates from https://translatewiki.net.

5 months agoFixed "or divider" issue described in #4773 by adding mb-2 below "or" divider
Nenad Vujicic [Wed, 29 May 2024 09:32:48 +0000 (11:32 +0200)]
Fixed "or divider" issue described in #4773 by adding mb-2 below "or" divider

5 months agoSocial sign-in: avoid re-authorization in `users_controller#create`
Milan Cvetkovic [Mon, 27 May 2024 14:40:53 +0000 (14:40 +0000)]
Social sign-in: avoid re-authorization in `users_controller#create`

It does not add any additional guards against malicious users:

Malicious user may attempt to invoke `POST /users/new` with bogus
values for `auth_provider` and `auth_uid` resulting
with a new account to which user would have a way to login, other than
sending a password reset request.

In some cases, re-authorization would introduce additional
"Please login to your social account", or "Are you sure you want to be logged in"
popup triggered by identity provider.

This PR removes the re-authorization request from `POST /users/new` in authorization flow.