Fixed a bug in how fields in /message/new were being pre-filled out.
When someone went to /message/new/:user the "Subject" are would be
pre-filled out with t('message.new.title'). The problem was that the
@title template variable was being used for two purposes, to set the
HTML <title> AND to pre-fill out the subject.
We don't always want these two to be the same, but sometimes we
do. E.g. when someone replies to a diary entry and visits
/message/new/:user?title=Foo we want Foo in the <title> and in the
pre-filled out Subject, and the same goes for replying to a message.
So I've split up the @title variable into @title and @subject.
Matt Amos [Thu, 2 Jul 2009 16:40:29 +0000 (16:40 +0000)]
Changed shortlink zoom level correction char to '-', as this seems to fare better with twitter et al.'s URL highlighting. Decoder is backwards-compatible with the old system.
Tom Hughes [Mon, 29 Jun 2009 17:11:50 +0000 (17:11 +0000)]
Go back to using < and > for navigation instead of the nasty looking
unicode arrows which aren't at all consistent with the use of | as the
separator.
Also remove some of the translations - there is no reason that I can
see to allow translations to completely change how the navigation control
is laid out.
Add B000FTFT (as well as B000FTF) to the list of layers we should
ignore when constructing the shortlink.
The shortlink was also broken for the new /?{node,way,relation}=id
construct since the code assumed that all URL parameters that weren't
lat/lon/zoom/layers could be safely ignored. I've added
node/way/relation to that list but for future-proofness it might be
better to simply check if there's anything left in ''args'' that we
don't know how to encode, rather than checking on values we know about
now.
I forgot to set fillColor/fillOpacity in commit [16214]. Without it
any area being rendered by OpenLayers would turn into a black hole
since the default fillOpacity is 100%.
The default OpenLayers.Layer.GML style can be nearly invisible when
viewed on the main map.
Set a style that's blue (since not a lot of things on the map are
blue), with strokeWidth 3 and opacity 50%. It makes things visible
enough without being too intrusive.
Make the printable_name() function call i18n.t to translate its
output. Makes e.g. "#{name}, v#{object.version.to_s}" which is used in
the changeset browser translatable.
I'm still not happy with how the anchor is constructed. we're linking
from /browse/changeset/1234 to e.g. node "[[366672999, v1]]" even
though the page we're linking to might take us to that node at version
2. The link should be "[[366672999]], v1" instead.
I mistakenly removed ''export.start_rjs.view_larger_map'' from en.yml
when removing ''browse.map.view_larger_map'' in changeset
[16196]. This broke the HTML feature in the Export dialog
(''translation missing: en, export, start_rjs, view_larger_map'' was
inserted instead)
The relation browser used the translated nominative model names of
Node/Way/Relation in /browse/relation/:id. And used the bad practice
of concating things together to translate them.
Delete browse.map.view_larger_map from a bunch of translations. It has kind-of been replaced by browse.map.larger.area but the translation isn't the same so I can't move them over
Tom Hughes [Sat, 27 Jun 2009 17:11:54 +0000 (17:11 +0000)]
Tidy up some recent commits:
- Simplify shortlinkPrefix by removing redundant code.
- Factor out duplicate code for displaying objects on maps.
- Reindent some stuff to make it more readable.
Introducing a new /browse/{node,way,relation,changeset}/{id}/map page
which is slippy map covering the screen showing the map data that is
in the small map at /browse/{node,way,relation,changeset}/{id}.
/browse/{node,way,relation,changeset}/{id} now contains a link to both
"View Larger Map" which has been changed to link to this new map
feature, and "View on main map" which as before links to the area
showing the feature on the main slippy map.
/browse/{node,way,relation,changeset}/{id}/map supports permalinks
using its own hacked version of updateLocation() (which doesn't set a
cookie), but shortlinks are not supported. The Edit/History/Export
links link back to the main map.