]> git.openstreetmap.org Git - rails.git/commitdiff
Completely remove form-action restrictions for OAuth callbacks
authorTom Hughes <tom@compton.nu>
Wed, 23 May 2018 11:09:21 +0000 (12:09 +0100)
committerTom Hughes <tom@compton.nu>
Wed, 23 May 2018 11:09:21 +0000 (12:09 +0100)
The CSP3 draft only allows a * rule match network schemes and
mobile devices often use callbacks to custom URL schemes.

app/controllers/oauth_controller.rb

index ae6d0983b8fbcb89f10c9ef123d515b3fc6ccb29..801d88a18020642b60c8546473d8aaef1eaf1963 100644 (file)
@@ -38,7 +38,7 @@ class OauthController < ApplicationController
   protected
 
   def oauth1_authorize
   protected
 
   def oauth1_authorize
-    append_content_security_policy_directives(:form_action => %w[*])
+    override_content_security_policy_directives(:form_action => false)
 
     if @token.invalidated?
       @message = t "oauth.authorize_failure.invalid"
 
     if @token.invalidated?
       @message = t "oauth.authorize_failure.invalid"