Make test names clearer

Merge remote-tracking branch 'upstream/pull/3862'

Merge pull request #3864 from ZhengLin-Li/patch-1

Change Save to Comment

Change Save to Comment

For comment submit buttons we currently have:

"Comment" (Changeset Comments)
"Add Comment" (Issue Comments)
"Comment" (Note Comments)
"Save" (Diary Comments)

So, to make them consistent, I'd propose to change "Save" to "Comment"

Add tests to ensure tokens are revoked

This ensures that tokens are revoked or invalidated when a user
is soft destroyed.

update-wiki-pages: adding retry and timeout

Merge pull request #3860 from gravitystorm/yaml_quoting

Quote ruby versions in yaml

Quote ruby versions in yaml

Without quotes these are parsed as numbers, which can cause subtle
problems. For example, "ruby: 3.0" is interpreted by the
ruby/setup-rubyaction as "ruby: 3", meaning 3.x instead of the
intended 3.0.x

Localisation updates from https://translatewiki.net.

Don't allow any abilities for inactive users

Revoke authentication tokens when a user is deleted

Fix eslint warnings

Fix eslint warnings

Merge remote-tracking branch 'upstream/pull/3848'

consistent naming of FOSSGIS routers

added manoeuvre numbering

Merge remote-tracking branch 'upstream/pull/3857'

Merge remote-tracking branch 'upstream/pull/3856'

Localisation updates from https://translatewiki.net.

Use buttons for dropdown toggles

These elements don't link to another page, and so there's no need
to use a link that leads to nowhere.

Precompile assets before running tests in actions workflows

Make tmp persistent in docker

Update storage volume configuration for docker

Use rails instead of rake

Wait for the button to be disabled, before checking the tooltip behaviour

Rather than sleeping for a fixed period, we can use Capybara's built-in
ability to wait for elements to be present. Since we're only changing
the state of existing elements though, we need to wait for their
"disabled" property to be set.

Fixes some timing-related problems with the test suite.

Merge remote-tracking branch 'upstream/pull/3852'

Fix redirection to wiki when terms are declined

Adds missing test to pick this up.

Fixes #3826.

Remove some old debugging comments

Fix new rubocop warnings

Update bundle

Merge remote-tracking branch 'upstream/pull/3851'

Bump eslint from 8.29.0 to 8.30.0

Bumps [eslint](https://github.com/eslint/eslint) from 8.29.0 to 8.30.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.29.0...v8.30.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix resource names for Oauth 2 bottons

Fixes #3850

added valhalla routing engine

renamed fossgis engine

Localisation updates from https://translatewiki.net.

Set the tooltip on the edit tab after the locale is set

Fixes #3839

Update OSGB date range for copyright

Merge pull request #3817 from LaoshuBaby/readme-translate-change

docs(README.md): add communities name translate guide

Rephrase the OCI description for clarity

Where the list of chapters come from is of interest to developers,
beyond just in the context of i18n. So make this topic into its own
item, rather than a sub-part of the general translation item.

Merge remote-tracking branch 'upstream/pull/3844'

Use fallbacks for OCI resource names

This uses the fallbacks for OCI translations. For example, if a
local chapter doesn't have an explicitly translated name, it will
use a template for osm-lc resources and fill in the appropriate
translated community name.

Fixes #3814

Fix new rubocop warnings

Update bundle

Bump osm-community-index from 5.3.1 to 5.4.0

Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.3.1 to 5.4.0.
- [Release notes](https://github.com/osmlab/osm-community-index/releases)
- [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md)
- [Commits](https://github.com/osmlab/osm-community-index/compare/v5.3.1...v5.4.0)

---
updated-dependencies:
- dependency-name: osm-community-index
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Localisation updates from https://translatewiki.net.

Avoid duplicate initialisation warnings

Fix eslint warnings

Merge remote-tracking branch 'upstream/pull/3606'

Run tests on ubuntu 20.04 and 22.04 with ruby 3.1

Ubuntu 22.04 actually uses ruby 3.0 but ruby/setup-ruby currently
only supports ruby 3.1 there so this is the best we can do.

Increase delay to improve test reliability

Set secure flag for matomo cookies

Allow matomo cookie timeouts to be configured

Localisation updates from https://translatewiki.net.

Merge remote-tracking branch 'upstream/pull/3832'

Bump nokogiri from 1.13.9 to 1.13.10

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.9 to 1.13.10.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.13.9...v1.13.10)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge remote-tracking branch 'upstream/pull/3830'

Merge remote-tracking branch 'upstream/pull/3828'

Remove tile_for_point SQL functions

This removes both the pl/pgsql version and the shared library version
of the `tile_for_point` SQL function. This function was only used in some
old migrations, and is not required for production usage.

Removing this function simplifies the installation and configuration for
new developers.

These SQL functions are separate from the `tile_for_point` ruby/C function
which is part of the quad_tile gem. This function is still used when
creating and updating database records.

Fixes #3110.

Remove fallback code for undefined history.pushState()

Update bundle

Localisation updates from https://translatewiki.net.

Only send user IDs to matomo when configured to do so

Merge remote-tracking branch 'upstream/pull/3821'

Merge remote-tracking branch 'upstream/pull/3825'

Merge remote-tracking branch 'upstream/pull/3822'

Merge remote-tracking branch 'upstream/pull/3126'

Bump eslint from 8.28.0 to 8.29.0

Bumps [eslint](https://github.com/eslint/eslint) from 8.28.0 to 8.29.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.28.0...v8.29.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Localisation updates from https://translatewiki.net.

Bump leaflet.locatecontrol from 0.78.0 to 0.79.0

Bumps [leaflet.locatecontrol](https://github.com/domoritz/leaflet-locatecontrol) from 0.78.0 to 0.79.0.
- [Release notes](https://github.com/domoritz/leaflet-locatecontrol/releases)
- [Changelog](https://github.com/domoritz/leaflet-locatecontrol/blob/gh-pages/CHANGELOG.md)
- [Commits](https://github.com/domoritz/leaflet-locatecontrol/compare/v0.78.0...v0.79.0)

---
updated-dependencies:
- dependency-name: leaflet.locatecontrol
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Add more testcases to changesets_controller

Extracted from pull request #1995

Make tooltip tests more robust

Merge remote-tracking branch 'upstream/pull/3688'

Merge remote-tracking branch 'upstream/pull/3820'

Use mail_to help to avoid handcrafting mailto links

This also reworks the user suspended page to avoid having html in
the translation strings.

Update bundle

Localisation updates from https://translatewiki.net.

fix(README.md): typo and grammar

Localisation updates from https://translatewiki.net.

docs(README.md): add communities name translate guide

In https://github.com/openstreetmap/openstreetmap-website/issues/3653 and https://github.com/openstreetmap/openstreetmap-website/issues/3814 noticed that communities name listed in https://www.openstreetmap.org/communities can't found in TranslateWiki

Merge pull request #3676 from harry-wood/notes-disappear-time

Display how long until a note will disappear

Update node modules

Merge remote-tracking branch 'upstream/pull/3301'

Fix new rubocop warnings

Update bundle

Localisation updates from https://translatewiki.net.

Merge remote-tracking branch 'upstream/pull/3809'

Merge remote-tracking branch 'upstream/pull/3808'

Bump leaflet from 1.9.2 to 1.9.3

Bumps [leaflet](https://github.com/Leaflet/Leaflet) from 1.9.2 to 1.9.3.
- [Release notes](https://github.com/Leaflet/Leaflet/releases)
- [Changelog](https://github.com/Leaflet/Leaflet/blob/main/CHANGELOG.md)
- [Commits](https://github.com/Leaflet/Leaflet/compare/v1.9.2...v1.9.3)

---
updated-dependencies:
- dependency-name: leaflet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump eslint from 8.27.0 to 8.28.0

Bumps [eslint](https://github.com/eslint/eslint) from 8.27.0 to 8.28.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.27.0...v8.28.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Merge remote-tracking branch 'upstream/pull/3805'

Merge remote-tracking branch 'upstream/pull/3804'

Merge remote-tracking branch 'upstream/pull/3803'

Use the mail_to method to construct a mailto link for browse tag values

This is easier than building a mailto link ourselves. Also implement
the missing title tag and write a test for it.

Enable more brakeman checks

These have been refactored already, so no longer need to be skipped.

Localisation updates from https://translatewiki.net.

Create a second title_user translation, to avoid using html_safe

Reconfigure the suspended flash message to avoid html_safe

This also avoids having raw html in the translation strings

Merge remote-tracking branch 'upstream/pull/3798'

Merge remote-tracking branch 'upstream/pull/3797'