]>
git.openstreetmap.org Git - rails.git/log
Shaun McDonald [Mon, 17 Nov 2008 18:53:09 +0000 (18:53 +0000)]
Adding validations for the length of node tags, and the presence of the id (and version). More tests, including some boiler plate tests.
Matt Amos [Mon, 17 Nov 2008 15:30:46 +0000 (15:30 +0000)]
Made user input parsing more robust in changeset query method. Added tests.
Shaun McDonald [Mon, 17 Nov 2008 15:00:19 +0000 (15:00 +0000)]
Verify that the key and value isn't getting mixed up by having them different. verify the error message is the same when returning the user conflict on closing changeset test.
Matt Amos [Mon, 17 Nov 2008 14:32:15 +0000 (14:32 +0000)]
Fixed some bugs in changeset query code. Added more test cases.
Matt Amos [Mon, 17 Nov 2008 11:59:42 +0000 (11:59 +0000)]
Added tests for changeset close method.
Matt Amos [Mon, 17 Nov 2008 11:45:50 +0000 (11:45 +0000)]
Implemented changeset tags updating via the update method.
Matt Amos [Mon, 17 Nov 2008 11:12:48 +0000 (11:12 +0000)]
Altered tests on AMF controller so that they give failures instead of errors. Return format seems to have changed, so someone who knows more about AMF controller should have a look.
Richard Fairhurst [Sun, 16 Nov 2008 13:30:02 +0000 (13:30 +0000)]
changeset comments and a couple of other small fixes
Shaun McDonald [Sat, 15 Nov 2008 01:11:27 +0000 (01:11 +0000)]
Freezing composite primary key so that we can apply TomH's patch to it, and that way Potlatch will work in Rails mode without a problem. Please test.
Richard Fairhurst [Fri, 14 Nov 2008 17:36:38 +0000 (17:36 +0000)]
finished Rails-friendly amf_controller. Note that this requires Tom's patched composite_primary_keys to work unless you tell Potlatch to use SQL reads
Shaun McDonald [Fri, 14 Nov 2008 17:28:16 +0000 (17:28 +0000)]
More unit test stubs
Shaun McDonald [Fri, 14 Nov 2008 16:26:56 +0000 (16:26 +0000)]
Unit tests work again. Fixed the set fixture class that I should. Adding 2 length checks to the user preference controller.
Shaun McDonald [Fri, 14 Nov 2008 02:06:04 +0000 (02:06 +0000)]
Adding some more unit test stubs that need filling out. Adding changeset tags fixture. Indentation fix in way model.
Shaun McDonald [Thu, 13 Nov 2008 17:20:40 +0000 (17:20 +0000)]
Adding some more diary entry tests. Making the RSS feed links more portable, by using the SERVER_URL constant. Fixing the validation for the length of the language of diary entries until the i18n branch is integrated.
Shaun McDonald [Wed, 12 Nov 2008 18:48:58 +0000 (18:48 +0000)]
Covering the case of an entry not being found. More diary entry tests.
Frederik Ramm [Wed, 12 Nov 2008 00:11:57 +0000 (00:11 +0000)]
replaced "wtf does this do" comment by something explaining what it does.
Shaun McDonald [Tue, 11 Nov 2008 18:33:08 +0000 (18:33 +0000)]
more diary entry test
Shaun McDonald [Tue, 11 Nov 2008 18:07:59 +0000 (18:07 +0000)]
more diary entry tests, and a minor fix to the relation member that makes the code a bit more readable.
Shaun McDonald [Mon, 10 Nov 2008 19:21:59 +0000 (19:21 +0000)]
slight more work on the diary test
Andy Allan [Mon, 10 Nov 2008 19:14:00 +0000 (19:14 +0000)]
Postgres adapter, and make migration 022 db-agnostic
Andy Allan [Mon, 10 Nov 2008 17:10:55 +0000 (17:10 +0000)]
nil protection - mysql however has a default for enums, which is why it wasn't a problem before
Matt Amos [Mon, 10 Nov 2008 15:41:05 +0000 (15:41 +0000)]
Made relations ordered. Added some tests for this. Otherwise interface is unchanged.
Matt Amos [Mon, 10 Nov 2008 15:37:34 +0000 (15:37 +0000)]
Ooops, forgot to commit the routes for the changeset query and include calls.
Andy Allan [Mon, 10 Nov 2008 11:47:20 +0000 (11:47 +0000)]
boolean correctness
Andy Allan [Mon, 10 Nov 2008 11:39:10 +0000 (11:39 +0000)]
forgot the test change from 11866
Andy Allan [Mon, 10 Nov 2008 11:32:17 +0000 (11:32 +0000)]
In YAML yes is a boolean keyword: also fix test that was erroneously asserting success
Richard Fairhurst [Sun, 9 Nov 2008 23:50:03 +0000 (23:50 +0000)]
0.6-friendly Potlatch (work in progress). DO NOT SET POTLATCH_USE_SQL=false as it won't work
Shaun McDonald [Sun, 9 Nov 2008 19:51:56 +0000 (19:51 +0000)]
adding first integration for testing user diaries, as multiple controllers are required. more work required.
Andy Allan [Sun, 9 Nov 2008 19:30:22 +0000 (19:30 +0000)]
remove indexes before renaming tables (some dbs have database-level index namespaces) and unsigned is also a mysqlism
Dave Stubbs [Sun, 9 Nov 2008 18:48:16 +0000 (18:48 +0000)]
amf get*_history tests and related fixes
Dave Stubbs [Sun, 9 Nov 2008 17:41:38 +0000 (17:41 +0000)]
a few more amf tests and associated bug fixes
Shaun McDonald [Sun, 9 Nov 2008 16:49:27 +0000 (16:49 +0000)]
fixing the tests due to a osm -> diffChange and moving to floats
Dave Stubbs [Sun, 9 Nov 2008 16:43:09 +0000 (16:43 +0000)]
update nodes/ways/relation XML to include user id as well as display name
Frederik Ramm [Sun, 9 Nov 2008 16:12:23 +0000 (16:12 +0000)]
return user id AND name with changeset get request
Andy Allan [Sun, 9 Nov 2008 16:11:42 +0000 (16:11 +0000)]
migrations: add specific method for nodes/ways/relations enum column
Frederik Ramm [Sun, 9 Nov 2008 15:52:10 +0000 (15:52 +0000)]
fix SCALE, make changeset GET use floats
Frederik Ramm [Sun, 9 Nov 2008 13:44:08 +0000 (13:44 +0000)]
require auth for close
Harry Wood [Sun, 9 Nov 2008 12:17:53 +0000 (12:17 +0000)]
cosmetic tweaks to 'login' and 'create account' screens
Frederik Ramm [Sun, 9 Nov 2008 12:06:05 +0000 (12:06 +0000)]
mini fix
Frederik Ramm [Sun, 9 Nov 2008 11:30:03 +0000 (11:30 +0000)]
make diff upload result a "diffResult" rather than "osm" document
Andy Allan [Sun, 9 Nov 2008 11:19:46 +0000 (11:19 +0000)]
move index dropping to remove_index method
Shaun McDonald [Sun, 9 Nov 2008 11:13:10 +0000 (11:13 +0000)]
bumping the version of composite primary keys for the amf controler as there are bugs in it
Harry Wood [Sun, 9 Nov 2008 10:57:05 +0000 (10:57 +0000)]
oops remove my test
Daniel Silverstone [Sun, 9 Nov 2008 10:41:48 +0000 (10:41 +0000)]
Update DB readme for PgSQL a bit
Frederik Ramm [Sat, 8 Nov 2008 19:55:13 +0000 (19:55 +0000)]
fix accidental commit of local config changes
Frederik Ramm [Sat, 8 Nov 2008 19:43:31 +0000 (19:43 +0000)]
fix version number return for "modify" sections of diff uploads
Dave Stubbs [Sat, 8 Nov 2008 19:41:29 +0000 (19:41 +0000)]
1st amf_controller tests, and some basic sanity check fixes
Daniel Silverstone [Sat, 8 Nov 2008 19:33:41 +0000 (19:33 +0000)]
Ignore the bits in tmp/
Daniel Silverstone [Sat, 8 Nov 2008 19:21:03 +0000 (19:21 +0000)]
CREATE FUNCTION statement for pgsql
Daniel Silverstone [Sat, 8 Nov 2008 19:18:22 +0000 (19:18 +0000)]
Support building a postgresql binding for maptile_for_point
Harry Wood [Sat, 8 Nov 2008 19:03:25 +0000 (19:03 +0000)]
cosmetic tweaks to user settings form + move 'Mapper since' field onto user profile view
Andy Allan [Sat, 8 Nov 2008 18:59:06 +0000 (18:59 +0000)]
correcting typo on gps_points fixtures
Andy Allan [Sat, 8 Nov 2008 18:44:38 +0000 (18:44 +0000)]
move fulltext indexes to monkeypatch, since not all dbs have a fulltext analogue
Andy Allan [Sat, 8 Nov 2008 18:04:36 +0000 (18:04 +0000)]
Move db engine changing into db adaptor monkeypatch
Andy Allan [Sat, 8 Nov 2008 17:39:16 +0000 (17:39 +0000)]
last of the auto_increments removed from the migrations
Andy Allan [Sat, 8 Nov 2008 17:08:51 +0000 (17:08 +0000)]
Fixing boo-boo in r11802 - but you can assign integers to booleans on all dbs
Andy Allan [Sat, 8 Nov 2008 16:47:02 +0000 (16:47 +0000)]
Moving AUTO_INCREMENTs to monkeypatching. Seems a bit hacky though
Harry Wood [Sat, 8 Nov 2008 16:41:51 +0000 (16:41 +0000)]
message with a logo and link to Contact page
Andy Allan [Sat, 8 Nov 2008 15:01:14 +0000 (15:01 +0000)]
Boolean correctness in migrations
Daniel Silverstone [Sat, 8 Nov 2008 14:11:45 +0000 (14:11 +0000)]
Make the confrm button into a confirm button
Matt Amos [Sat, 8 Nov 2008 14:07:34 +0000 (14:07 +0000)]
Error message for version mismatch is now more informative.
Andy Allan [Sat, 8 Nov 2008 12:30:42 +0000 (12:30 +0000)]
move bigint_pk id column into table def, no need to be an add_column
Shaun McDonald [Sat, 8 Nov 2008 12:16:42 +0000 (12:16 +0000)]
fixing one cmd that was missed in the resync
Shaun McDonald [Sat, 8 Nov 2008 11:52:58 +0000 (11:52 +0000)]
Resyncing from head 10895:11795
Shaun McDonald [Sat, 8 Nov 2008 11:34:58 +0000 (11:34 +0000)]
Adding some diary fixtures and test stubs
Andy Allan [Sat, 8 Nov 2008 11:01:39 +0000 (11:01 +0000)]
Change bigint id column to monkeypatching-friendly syntax
Dave Stubbs [Sat, 8 Nov 2008 10:48:07 +0000 (10:48 +0000)]
more boolean correcting
Matt Amos [Fri, 7 Nov 2008 18:24:34 +0000 (18:24 +0000)]
Added a query method for querying bounding boxes, times and users of changesets. Needs (much) more testing.
Shaun McDonald [Fri, 7 Nov 2008 15:08:43 +0000 (15:08 +0000)]
fix the indentation only
Andy Allan [Fri, 7 Nov 2008 13:51:09 +0000 (13:51 +0000)]
some boolean correctness work
Andy Allan [Fri, 7 Nov 2008 13:27:03 +0000 (13:27 +0000)]
add fixme
Andy Allan [Fri, 7 Nov 2008 13:24:18 +0000 (13:24 +0000)]
use boolean flags when using boolean columns
Andy Allan [Fri, 7 Nov 2008 11:36:34 +0000 (11:36 +0000)]
Booleans should be true/false - coding style comments welcome
Matt Amos [Fri, 7 Nov 2008 11:36:00 +0000 (11:36 +0000)]
D'oh! Fixed stupid errors in changeset controller.
Andy Allan [Fri, 7 Nov 2008 11:21:46 +0000 (11:21 +0000)]
users fixtures should all have creation times
Andy Allan [Fri, 7 Nov 2008 11:20:25 +0000 (11:20 +0000)]
Booleans should be true/false for compatibility with other db adapters
Matt Amos [Thu, 6 Nov 2008 19:10:19 +0000 (19:10 +0000)]
Ooops. Added missing access control to changeset controller.
Matt Amos [Thu, 6 Nov 2008 18:42:06 +0000 (18:42 +0000)]
Added a changeset/#id/include method to POST to to expand the bounding box.
Matt Amos [Thu, 6 Nov 2008 17:56:24 +0000 (17:56 +0000)]
Implemented changeset bounding box handling for relations, based on the conversation on the mailing list. Its a bit complex...
Shaun McDonald [Thu, 6 Nov 2008 17:15:22 +0000 (17:15 +0000)]
Doing the update version part of the migration in chunks of 10000 instead of all at once so that MySQL doesn't choke with running out of table locks.
Shaun McDonald [Thu, 6 Nov 2008 14:20:07 +0000 (14:20 +0000)]
Removing depricated config option in the development env
Shaun McDonald [Wed, 5 Nov 2008 18:42:38 +0000 (18:42 +0000)]
Fixing the migration so that it will better match the live databetter.
Shaun McDonald [Wed, 5 Nov 2008 17:37:14 +0000 (17:37 +0000)]
Updating the cycle map to use all zoom levels as per Andy Allan's message.
Matt Amos [Tue, 4 Nov 2008 15:52:22 +0000 (15:52 +0000)]
Added first attempt at bounding box support in changesets and tests for the same.
Shaun McDonald [Tue, 4 Nov 2008 13:54:45 +0000 (13:54 +0000)]
Minor fix (integer => bigint) to one of the migrations so that they will run fully again.
Shaun McDonald [Mon, 3 Nov 2008 18:54:19 +0000 (18:54 +0000)]
Adding an extra test to make sure that the correct response is returned when an invalid changeset action is uploaded.
Shaun McDonald [Mon, 3 Nov 2008 18:05:19 +0000 (18:05 +0000)]
Additional api tests for the changes. Also making sure that you cannot request a change of 0 length, so that you can detect erronious input.
Shaun McDonald [Mon, 3 Nov 2008 00:12:18 +0000 (00:12 +0000)]
Adding a restriction to prevent more than 2000 nodes to be added to any way. Tests still need to be written. Capabilities api request also updated.
Shaun McDonald [Fri, 31 Oct 2008 18:02:12 +0000 (18:02 +0000)]
Add a description meta tag for the all web pages. Wording probably needs to be improved.
Shaun McDonald [Thu, 30 Oct 2008 18:50:45 +0000 (18:50 +0000)]
Starting the gpx trace testing with additional fixtures
Matt Amos [Wed, 29 Oct 2008 16:27:15 +0000 (16:27 +0000)]
Added custom validator for UTF-8 strings.
Shaun McDonald [Wed, 29 Oct 2008 15:45:48 +0000 (15:45 +0000)]
add a comment about why the error handler is required, as per mail from TomH. Also adding the option so that we are using the old style of migrations, rather than the 2.1+ migrations.
Matt Amos [Wed, 29 Oct 2008 15:33:23 +0000 (15:33 +0000)]
Better error message and test for invalid UTF-8 sequences.
Tom Hughes [Wed, 29 Oct 2008 13:49:45 +0000 (13:49 +0000)]
Put back the units on all the zero values. Just because you can remove
something doesn't mean it's a good idea...
Hugh Barnes [Wed, 29 Oct 2008 13:05:14 +0000 (13:05 +0000)]
Fix for bug #1242, css foreground set + css shorthands used
Shaun McDonald [Tue, 28 Oct 2008 20:42:48 +0000 (20:42 +0000)]
Updating to use Rails 2.1.2. Moving the gem dependancies to the config/environment.rb file. Moving the vendor/plugins externals into our svn.
Andy Allan [Tue, 28 Oct 2008 18:34:05 +0000 (18:34 +0000)]
message title shouldn't accept invalid utf-8 sequences - test currently fails
Matt Amos [Tue, 28 Oct 2008 15:01:17 +0000 (15:01 +0000)]
Made full test a bit more thorough.
Matt Amos [Tue, 28 Oct 2008 14:49:51 +0000 (14:49 +0000)]
Added tests for relations for way/relation and a bit of DRYing up.
Shaun McDonald [Tue, 28 Oct 2008 12:49:51 +0000 (12:49 +0000)]
Adding stub functional test files for all the controllers that should have tests written for them.