]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
19 months agoswitch CLI search command to python implementation
Sarah Hoffmann [Wed, 24 May 2023 20:54:54 +0000 (22:54 +0200)]
switch CLI search command to python implementation

19 months agomake localisation of results explicit
Sarah Hoffmann [Wed, 24 May 2023 16:12:34 +0000 (18:12 +0200)]
make localisation of results explicit

Localisation was previously done as part of the formatting but might
also be useful on its own when working with the results directly.

19 months agoadd API functions for search functions
Sarah Hoffmann [Wed, 24 May 2023 15:43:28 +0000 (17:43 +0200)]
add API functions for search functions

Search is now split into three functions: for free-text search,
for structured search and for search by category. Note that the
free-text search does not have as many hidden features like
coordinate search. Use the search parameters for that.

19 months agoimplement actual database searches
Sarah Hoffmann [Wed, 24 May 2023 11:52:31 +0000 (13:52 +0200)]
implement actual database searches

19 months agoimplement search builder
Sarah Hoffmann [Tue, 23 May 2023 09:20:34 +0000 (11:20 +0200)]
implement search builder

19 months agoimplement token assignment
Sarah Hoffmann [Mon, 22 May 2023 13:49:03 +0000 (15:49 +0200)]
implement token assignment

19 months agoadd query analyser for legacy tokenizer
Sarah Hoffmann [Mon, 22 May 2023 09:07:14 +0000 (11:07 +0200)]
add query analyser for legacy tokenizer

19 months agoadd factory for query analyzer
Sarah Hoffmann [Mon, 22 May 2023 07:23:19 +0000 (09:23 +0200)]
add factory for query analyzer

19 months agoquery analyzer for ICU tokenizer
Sarah Hoffmann [Mon, 22 May 2023 06:46:19 +0000 (08:46 +0200)]
query analyzer for ICU tokenizer

19 months agoadd data structure for tokenized query
Sarah Hoffmann [Sat, 20 May 2023 21:46:15 +0000 (23:46 +0200)]
add data structure for tokenized query

19 months agoMerge pull request #3064 from lonvia/clicmd-debug-output
Sarah Hoffmann [Fri, 19 May 2023 06:55:26 +0000 (08:55 +0200)]
Merge pull request #3064 from lonvia/clicmd-debug-output

Enable debug output on command line

19 months agoenable debug output on command line
Sarah Hoffmann [Thu, 18 May 2023 20:37:46 +0000 (22:37 +0200)]
enable debug output on command line

19 months agoMerge pull request #3063 from lonvia/variable-parameters
Sarah Hoffmann [Thu, 18 May 2023 20:27:18 +0000 (22:27 +0200)]
Merge pull request #3063 from lonvia/variable-parameters

Rework how search parameters are handed to the Python API

19 months agofix use of subquery in reverse
Sarah Hoffmann [Thu, 18 May 2023 18:27:07 +0000 (20:27 +0200)]
fix use of subquery in reverse

19 months agomove zoom_to_rank computation to extra file
Sarah Hoffmann [Thu, 18 May 2023 16:29:41 +0000 (18:29 +0200)]
move zoom_to_rank computation to extra file

19 months agoadd tests for parameter converter
Sarah Hoffmann [Thu, 18 May 2023 16:09:07 +0000 (18:09 +0200)]
add tests for parameter converter

19 months agoMerge pull request #3062 from lonvia/enable-psycopg
Sarah Hoffmann [Thu, 18 May 2023 16:07:11 +0000 (18:07 +0200)]
Merge pull request #3062 from lonvia/enable-psycopg

Add support for psycopg 3 in the frontend

19 months agoswitch API parameters to keyword arguments
Sarah Hoffmann [Thu, 18 May 2023 15:42:23 +0000 (17:42 +0200)]
switch API parameters to keyword arguments

This switches the input parameters for API calls to a generic
keyword argument catch-all which is then loaded into a dataclass
where the parameters are checked and forwarded to internal
function.

The dataclass gives more flexibility with the parameters and makes
it easier to reuse common parameters for the different API calls.

19 months agoactions: run tests against psycopg
Sarah Hoffmann [Thu, 18 May 2023 11:03:03 +0000 (13:03 +0200)]
actions: run tests against psycopg

19 months agoenable API use with psycopg 3
Sarah Hoffmann [Thu, 18 May 2023 11:00:59 +0000 (13:00 +0200)]
enable API use with psycopg 3

19 months agoMerge pull request #3050 from mtmail/tiger-check-if-database-frozen
Sarah Hoffmann [Mon, 8 May 2023 14:35:31 +0000 (16:35 +0200)]
Merge pull request #3050 from mtmail/tiger-check-if-database-frozen

when adding Tiger data, check first if database is in frozen state

19 months agowhen adding Tiger data, check first if database is in frozen state
Marc Tobias [Tue, 2 May 2023 16:37:36 +0000 (18:37 +0200)]
when adding Tiger data, check first if database is in frozen state

19 months agoMerge pull request #3054 from lonvia/add-amenity-to-documentation
Sarah Hoffmann [Mon, 8 May 2023 09:12:17 +0000 (11:12 +0200)]
Merge pull request #3054 from lonvia/add-amenity-to-documentation

Docs: reintroduce amenity parameter for structured search

19 months agodocs: reintroduce amenity parameter for structured search
Sarah Hoffmann [Mon, 8 May 2023 08:24:12 +0000 (10:24 +0200)]
docs: reintroduce amenity parameter for structured search

20 months agoMerge pull request #3006 from biswajit-k/generalize-filter
Sarah Hoffmann [Tue, 11 Apr 2023 17:20:08 +0000 (19:20 +0200)]
Merge pull request #3006 from biswajit-k/generalize-filter

generalize filter function for sanitizers

20 months agoMerge pull request #3030 from lonvia/interpolation-corner-cases
Sarah Hoffmann [Fri, 7 Apr 2023 11:59:52 +0000 (13:59 +0200)]
Merge pull request #3030 from lonvia/interpolation-corner-cases

Fix a number of corner cases with interpolation splitting

20 months agofix a number of corner cases with interpolation splitting
Sarah Hoffmann [Thu, 6 Apr 2023 14:54:00 +0000 (16:54 +0200)]
fix a number of corner cases with interpolation splitting

Snapping a line to a point before splitting was meant to ensure
that the split point is really on the line. However, ST_Snap() does
not always behave well for this case. It may shorten the interpolation
line in some cases with the result that two points housenumbers
suddenly fall on the same point. It might also shorten the line down
to a single point which then makes ST_Split() crash.

Switch to a combination of ST_LineLocatePoint and ST_LineSubString
instead, which guarantees to keep the original geometry. Explicitly
handle the corner cases, where the split point falls on the beginning
or end of the line.

20 months agouse place_to_be_deleted when force deleting objects
Sarah Hoffmann [Tue, 4 Apr 2023 09:09:17 +0000 (11:09 +0200)]
use place_to_be_deleted when force deleting objects

20 months agoMerge pull request #3023 from lonvia/lookup-api
Sarah Hoffmann [Mon, 3 Apr 2023 14:20:47 +0000 (16:20 +0200)]
Merge pull request #3023 from lonvia/lookup-api

Python implementation of Lookup API

20 months agoswitch CLI lookup command to Python implementation
Sarah Hoffmann [Mon, 3 Apr 2023 12:38:40 +0000 (14:38 +0200)]
switch CLI lookup command to Python implementation

20 months agoadd lookup call to server glue
Sarah Hoffmann [Mon, 3 Apr 2023 10:11:23 +0000 (12:11 +0200)]
add lookup call to server glue

20 months agoadd tests for new lookup API
Sarah Hoffmann [Mon, 3 Apr 2023 09:23:51 +0000 (11:23 +0200)]
add tests for new lookup API

20 months agorename lookup() API to details and add lookup call
Sarah Hoffmann [Mon, 3 Apr 2023 09:11:11 +0000 (11:11 +0200)]
rename lookup() API to details and add lookup call

The initial plan to serve /details and /lookup endpoints from
the same API call turned out to be impractical, so the API now
also has deparate functions for both.

20 months agopython lookup: add function for simple lookups
Sarah Hoffmann [Mon, 3 Apr 2023 08:40:38 +0000 (10:40 +0200)]
python lookup: add function for simple lookups

20 months agopython lookup: factor out finding in tables into own function
Sarah Hoffmann [Mon, 3 Apr 2023 08:00:42 +0000 (10:00 +0200)]
python lookup: factor out finding in tables into own function

20 months agoMerge pull request #3021 from lonvia/readd-postalcode-relations
Sarah Hoffmann [Mon, 3 Apr 2023 10:11:49 +0000 (12:11 +0200)]
Merge pull request #3021 from lonvia/readd-postalcode-relations

Flex style: reinstate postalcode relations

20 months agobdd: disable detail tests searching by place ID
Sarah Hoffmann [Mon, 3 Apr 2023 08:07:06 +0000 (10:07 +0200)]
bdd: disable detail tests searching by place ID

Place IDs are not stable and cannot be used in tests.

20 months agoflex style: reinstate postcode boundaries
Sarah Hoffmann [Mon, 3 Apr 2023 07:17:50 +0000 (09:17 +0200)]
flex style: reinstate postcode boundaries

Postcode boundaries don't have a name, so need to be imported
unconditionally.

20 months agogeneralize filter for sanitizers
biswajit-k [Sat, 11 Mar 2023 08:22:07 +0000 (13:52 +0530)]
generalize filter for sanitizers

20 months agoMerge pull request #3019 from lonvia/add-data-postprocessing
Sarah Hoffmann [Fri, 31 Mar 2023 20:19:46 +0000 (22:19 +0200)]
Merge pull request #3019 from lonvia/add-data-postprocessing

Add postprocessing to add-data function

20 months agocall osm2pgsql postprocessing flush_deleted_places() when adding data
Sarah Hoffmann [Tue, 28 Mar 2023 12:48:41 +0000 (14:48 +0200)]
call osm2pgsql postprocessing flush_deleted_places() when adding data

20 months agoMerge pull request #3020 from lonvia/reverse-api
Sarah Hoffmann [Fri, 31 Mar 2023 16:01:50 +0000 (18:01 +0200)]
Merge pull request #3020 from lonvia/reverse-api

Python implementation of reverse

20 months agolimit results for country lookup
Sarah Hoffmann [Thu, 30 Mar 2023 07:58:02 +0000 (09:58 +0200)]
limit results for country lookup

20 months agoadd BDD tests for new layers parameter
Sarah Hoffmann [Wed, 29 Mar 2023 18:49:34 +0000 (20:49 +0200)]
add BDD tests for new layers parameter

20 months agopython reverse: add support for point geometries in interpolations
Sarah Hoffmann [Wed, 29 Mar 2023 15:21:33 +0000 (17:21 +0200)]
python reverse: add support for point geometries in interpolations

21 months agoadd wsgi entry point for falcon server
Sarah Hoffmann [Tue, 28 Mar 2023 13:05:52 +0000 (15:05 +0200)]
add wsgi entry point for falcon server

21 months agoadd wsgi entry point for starlette
Sarah Hoffmann [Tue, 28 Mar 2023 13:03:00 +0000 (15:03 +0200)]
add wsgi entry point for starlette

uvicorn needs a parameter-free function to start.

21 months agoignore broken data in interpolation table
Sarah Hoffmann [Tue, 28 Mar 2023 12:57:39 +0000 (14:57 +0200)]
ignore broken data in interpolation table

21 months agodisable prepared statements
Sarah Hoffmann [Tue, 28 Mar 2023 12:53:45 +0000 (14:53 +0200)]
disable prepared statements

Prepared statements do not work well with the partial indexes that
Nominatim uses because all Python constants are replaced with
parameters. A query like:

  placex.select().where(placex.c.rank_address.between(4, 25)

gets translated into a prepared query with two parameters:

  SELECT * FROM placex WHERE rank_address BETWEEN %s and %s

And this does not work with a partial index of:

  CREATE INDEX on placex(geometry) WHERE rank_address between 4 and 25

21 months agoswitch reverse CLI command to Python implementation
Sarah Hoffmann [Sun, 26 Mar 2023 16:09:33 +0000 (18:09 +0200)]
switch reverse CLI command to Python implementation

21 months agomake sure PHP and Python reverse code does the same
Sarah Hoffmann [Sun, 26 Mar 2023 10:22:34 +0000 (12:22 +0200)]
make sure PHP and Python reverse code does the same

The only allowable difference is precision of coordinates. Python uses
a precision of 7 digits where possible, which corresponds to the
precision of OSM data.

Also fixes some smaller bugs found by the BDD tests.

21 months agoadd server glue for reverse API call
Sarah Hoffmann [Sat, 25 Mar 2023 16:04:02 +0000 (17:04 +0100)]
add server glue for reverse API call

21 months agoadd output formatters for ReverseResults
Sarah Hoffmann [Fri, 24 Mar 2023 20:45:47 +0000 (21:45 +0100)]
add output formatters for ReverseResults

These formatters are written in a way that they can be reused for
search results later.

21 months agoignore NotImplementedErrors when compiling SQL
Sarah Hoffmann [Fri, 24 Mar 2023 10:16:02 +0000 (11:16 +0100)]
ignore NotImplementedErrors when compiling SQL

21 months agofactor out layer checks in reverse function
Sarah Hoffmann [Fri, 24 Mar 2023 09:08:01 +0000 (10:08 +0100)]
factor out layer checks in reverse function

21 months agopython: implement reverse lookup function
Sarah Hoffmann [Thu, 23 Mar 2023 21:38:37 +0000 (22:38 +0100)]
python: implement reverse lookup function

The implementation follows for most part the PHP code but introduces an
additional layer parameter with which the kind of places to be returned
can be restricted. This replaces the hard-coded exclusion lists.

21 months agoadd python implementation of reverse
Sarah Hoffmann [Tue, 21 Mar 2023 23:07:17 +0000 (00:07 +0100)]
add python implementation of reverse

This adds an additional layer parameter and slightly changes the
queries to do more efficient lookups for large area features.

21 months agoapi: make details parameter optional
Sarah Hoffmann [Tue, 21 Mar 2023 16:42:53 +0000 (17:42 +0100)]
api: make details parameter optional

21 months agoapi: generalize error handling
Sarah Hoffmann [Tue, 21 Mar 2023 15:24:26 +0000 (16:24 +0100)]
api: generalize error handling

Return a consistent error response which takes into account the chosen
content type. Also adds tests for V1 server glue.

21 months agosplit SearchResult type
Sarah Hoffmann [Tue, 14 Mar 2023 13:21:35 +0000 (14:21 +0100)]
split SearchResult type

Use adapted types for the different result types. This makes it
easier to have adapted output formatting and means there are only
result fields that are filled.

21 months agoMerge pull request #3013 from mtmail/changelog-4-2-x
Sarah Hoffmann [Thu, 23 Mar 2023 08:20:25 +0000 (09:20 +0100)]
Merge pull request #3013 from mtmail/changelog-4-2-x

update ChangeLog to verison 4.2.2

21 months agoupdate ChangeLog to verison 4.2.2
marc tobias [Wed, 22 Mar 2023 22:45:59 +0000 (23:45 +0100)]
update ChangeLog to verison 4.2.2

21 months agoMerge pull request #3011 from lonvia/fix-flex-scripts
Sarah Hoffmann [Tue, 21 Mar 2023 08:58:53 +0000 (09:58 +0100)]
Merge pull request #3011 from lonvia/fix-flex-scripts

Fix extra tag handling in some flex scripts

21 months agoMerge pull request #3010 from lonvia/adapt-zoom-for-reverse
Sarah Hoffmann [Tue, 21 Mar 2023 07:56:25 +0000 (08:56 +0100)]
Merge pull request #3010 from lonvia/adapt-zoom-for-reverse

Minor adjustments to reverse zoom translation

21 months agoremove more tags from full style
Sarah Hoffmann [Mon, 20 Mar 2023 20:42:24 +0000 (21:42 +0100)]
remove more tags from full style

The full style should only save the necessary tags needed for
processing.

21 months agofix handling of unused extra tags
Sarah Hoffmann [Mon, 20 Mar 2023 20:20:27 +0000 (21:20 +0100)]
fix handling of unused extra tags

The tags can only be moved to extra tags after the main tags have been
handled.

21 months agominor adjustment to reverse zoom translation
Sarah Hoffmann [Mon, 20 Mar 2023 19:47:42 +0000 (20:47 +0100)]
minor adjustment to reverse zoom translation

Add a 'village' zoom level at 13 between town and neighbourhood
and a all locality-like objects for zoom 15. These zoom levels had
the same behaviour as the lower level so far. However, the distinction
for village and locality may be useful at times.

21 months agoMerge pull request #3003 from lonvia/rework-bdd-api-tests
Sarah Hoffmann [Fri, 10 Mar 2023 09:01:24 +0000 (10:01 +0100)]
Merge pull request #3003 from lonvia/rework-bdd-api-tests

Reorganize code around BDD API tests and extend reverse API tests

21 months agobdd: be more fuzzy with coordinate comparisons
Sarah Hoffmann [Thu, 9 Mar 2023 20:47:29 +0000 (21:47 +0100)]
bdd: be more fuzzy with coordinate comparisons

21 months agoavoid recent Python dialect
Sarah Hoffmann [Thu, 9 Mar 2023 19:57:43 +0000 (20:57 +0100)]
avoid recent Python dialect

21 months agofix polygon simplification in reverse results
Sarah Hoffmann [Thu, 9 Mar 2023 19:24:07 +0000 (20:24 +0100)]
fix polygon simplification in reverse results

polygon_threshold has never really worked for reverse.

21 months agobdd: extend reverse API tests for format checks
Sarah Hoffmann [Thu, 9 Mar 2023 19:20:50 +0000 (20:20 +0100)]
bdd: extend reverse API tests for format checks

Reorganise the API reverse tests and extend the checks for the
output format, testing for all expected fields.

21 months agobdd: add tests for valid debug output
Sarah Hoffmann [Thu, 9 Mar 2023 19:10:51 +0000 (20:10 +0100)]
bdd: add tests for valid debug output

21 months agobdd: replace old formatting strings
Sarah Hoffmann [Thu, 9 Mar 2023 18:49:55 +0000 (19:49 +0100)]
bdd: replace old formatting strings

21 months agobdd: more format checks for reverse XML
Sarah Hoffmann [Thu, 9 Mar 2023 18:40:24 +0000 (19:40 +0100)]
bdd: more format checks for reverse XML

21 months agobdd: new step variant 'result contains in field'
Sarah Hoffmann [Thu, 9 Mar 2023 18:31:21 +0000 (19:31 +0100)]
bdd: new step variant 'result contains in field'

This replaces the + notation for recursing into result dictionaries.

21 months agobdd: factor out computation of result to-check lists
Sarah Hoffmann [Thu, 9 Mar 2023 17:01:45 +0000 (18:01 +0100)]
bdd: factor out computation of result to-check lists

21 months agobdd: replace property_list construct with standard check functions
Sarah Hoffmann [Thu, 9 Mar 2023 16:55:27 +0000 (17:55 +0100)]
bdd: replace property_list construct with standard check functions

21 months agobdd: remove special case for osm_type field
Sarah Hoffmann [Thu, 9 Mar 2023 16:44:34 +0000 (17:44 +0100)]
bdd: remove special case for osm_type field

The fuzzy field check hide cover formatting errors. Use 'osm' when
only caring about the conent.

21 months agobdd: reorganise field comparisons
Sarah Hoffmann [Thu, 9 Mar 2023 16:05:05 +0000 (17:05 +0100)]
bdd: reorganise field comparisons

Move comparision on Field values from assert_field() into a
comparator class. Replace BadRowValueAssert with a simpler
check_row() function.

21 months agobdd: use new check_for_attributes() function also in steps
Sarah Hoffmann [Thu, 9 Mar 2023 15:44:07 +0000 (16:44 +0100)]
bdd: use new check_for_attributes() function also in steps

21 months agobdd: fully check correctness of geojson and geocodejson
Sarah Hoffmann [Thu, 9 Mar 2023 15:36:46 +0000 (16:36 +0100)]
bdd: fully check correctness of geojson and geocodejson

Parse code now checks presence of all required fields and exports
all fields for inspection.

21 months agobdd: remove OrderedDict
Sarah Hoffmann [Thu, 9 Mar 2023 15:08:39 +0000 (16:08 +0100)]
bdd: remove OrderedDict

dicts are guaranteed to keep insertion order by since Python 3.7, making
use of ORderedDict mute.

21 months agoMerge pull request #2993 from biswajit-k/delete-tags
Sarah Hoffmann [Thu, 9 Mar 2023 13:31:45 +0000 (14:31 +0100)]
Merge pull request #2993 from biswajit-k/delete-tags

Adds sanitizer for preventing certain tags to enter search index based on parameters

21 months agoAdds sanitizer for preventing certain tags to enter search index based on parameters
biswajit-k [Thu, 2 Mar 2023 14:55:06 +0000 (20:25 +0530)]
Adds sanitizer for preventing certain tags to enter search index based on parameters

fix: pylint error

added docs for delete tags sanitizer

fixed typos in docs and code comments

fix: python typechecking error

fixed rank address type

Revert "fixed typos in docs and code comments"

This reverts commit 6839eea755a87f557895f30524fb5c03dd983d60.

added default parameters and refactored code

added test for all parameters

21 months agoMerge pull request #2999 from biswajit-k/fix-typos
Sarah Hoffmann [Wed, 8 Mar 2023 07:55:27 +0000 (08:55 +0100)]
Merge pull request #2999 from biswajit-k/fix-typos

fixed typos in docs and code comments

21 months agofixed typos in docs and code comments
biswajit-k [Mon, 6 Mar 2023 11:39:38 +0000 (17:09 +0530)]
fixed typos in docs and code comments

22 months agoadd latest security incident
Sarah Hoffmann [Wed, 22 Feb 2023 10:24:04 +0000 (11:24 +0100)]
add latest security incident

Also removes 3.6 which is no longer supported.

22 months agoharmonize flags for PHP's htmlspecialchars
Sarah Hoffmann [Mon, 20 Feb 2023 15:46:53 +0000 (16:46 +0100)]
harmonize flags for PHP's htmlspecialchars

22 months agoadapt PHP tests for debug output
Sarah Hoffmann [Mon, 20 Feb 2023 15:23:28 +0000 (16:23 +0100)]
adapt PHP tests for debug output

22 months agoproperly encode special HTML characters in debug mode
Sarah Hoffmann [Mon, 20 Feb 2023 14:41:04 +0000 (15:41 +0100)]
properly encode special HTML characters in debug mode

22 months agoMerge pull request #2986 from mtmail/add-more-languages-from-osm-wiki
Sarah Hoffmann [Mon, 20 Feb 2023 10:12:08 +0000 (11:12 +0100)]
Merge pull request #2986 from mtmail/add-more-languages-from-osm-wiki

sp_wiki_loader: add more default languages

22 months agosp_wiki_loader: add more default languages
marc tobias [Fri, 17 Feb 2023 23:31:21 +0000 (00:31 +0100)]
sp_wiki_loader: add more default languages

22 months agoadd timestamp to debug SQL output
Sarah Hoffmann [Sat, 18 Feb 2023 08:49:30 +0000 (09:49 +0100)]
add timestamp to debug SQL output

22 months agoadd warning for reverse index migration
Sarah Hoffmann [Sat, 18 Feb 2023 08:43:37 +0000 (09:43 +0100)]
add warning for reverse index migration

22 months agoMerge pull request #2985 from lonvia/fix-place-rank-inheritance
Sarah Hoffmann [Sat, 18 Feb 2023 08:35:19 +0000 (09:35 +0100)]
Merge pull request #2985 from lonvia/fix-place-rank-inheritance

Restrict place rank inheritance to address items

22 months agorestrict place rank inheritance to address items
Sarah Hoffmann [Fri, 17 Feb 2023 15:25:26 +0000 (16:25 +0100)]
restrict place rank inheritance to address items

Place tags must have no influence on street- or POI-level
objects.

22 months agoMerge pull request #2983 from lonvia/improve-reverse-place-node-lookup
Sarah Hoffmann [Fri, 17 Feb 2023 14:51:55 +0000 (15:51 +0100)]
Merge pull request #2983 from lonvia/improve-reverse-place-node-lookup

Improve reverse place node lookup

22 months agouse reverse buffered index for search within country
Sarah Hoffmann [Fri, 17 Feb 2023 10:27:50 +0000 (11:27 +0100)]
use reverse buffered index for search within country

22 months agospeed up reverse lookup of place nodes
Sarah Hoffmann [Fri, 17 Feb 2023 09:31:49 +0000 (10:31 +0100)]
speed up reverse lookup of place nodes

Add a special index that contains the place nodes buffered by their
respective area according to their search rank. This replaces the
maximum area search for place nodes and reduces drastically the number
of place nodes that need to be retrieved.