]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
4 years agoactions: update apt repo before installing software
Sarah Hoffmann [Mon, 16 Nov 2020 09:14:38 +0000 (10:14 +0100)]
actions: update apt repo before installing software

4 years agoMerge pull request #2046 from lonvia/less-parallel-ranking
Sarah Hoffmann [Fri, 6 Nov 2020 08:39:07 +0000 (09:39 +0100)]
Merge pull request #2046 from lonvia/less-parallel-ranking

Only index larger batches for rank 30

4 years agoonly index larger batches for rank 30
Sarah Hoffmann [Thu, 5 Nov 2020 21:10:30 +0000 (22:10 +0100)]
only index larger batches for rank 30

Fixes #2045.

4 years agoMerge pull request #2041 from lonvia/address-ranks-belgium
Sarah Hoffmann [Tue, 3 Nov 2020 15:23:35 +0000 (16:23 +0100)]
Merge pull request #2041 from lonvia/address-ranks-belgium

Adapt admin_levels for Belgium

4 years agoadapt admin_levels for Belgium
Sarah Hoffmann [Tue, 3 Nov 2020 09:46:52 +0000 (10:46 +0100)]
adapt admin_levels for Belgium

Fixes #272.

4 years agoMerge pull request #2038 from lonvia/addresses-for-large-areas
Sarah Hoffmann [Tue, 3 Nov 2020 07:49:01 +0000 (08:49 +0100)]
Merge pull request #2038 from lonvia/addresses-for-large-areas

Improve addresses for large areas

4 years agoMerge pull request #2039 from lonvia/migration-for-ui
Sarah Hoffmann [Tue, 3 Nov 2020 07:48:45 +0000 (08:48 +0100)]
Merge pull request #2039 from lonvia/migration-for-ui

Add  migration hints for UI removal and remove tests for icon attribute

4 years agoremove tests for icon attribute
Sarah Hoffmann [Mon, 2 Nov 2020 15:46:29 +0000 (16:46 +0100)]
remove tests for icon attribute

The icon attribute requires the CONST_MapIcon_URL to be present
which we cannot guarantee for the tests.

4 years agodocs: add migration hints for removed UI
Sarah Hoffmann [Mon, 2 Nov 2020 15:34:17 +0000 (16:34 +0100)]
docs: add migration hints for removed UI

4 years agouse different area estimates for large countries
Sarah Hoffmann [Mon, 2 Nov 2020 10:41:53 +0000 (11:41 +0100)]
use different area estimates for large countries

4 years agoadapt tests to rank changes of natural
Sarah Hoffmann [Sat, 31 Oct 2020 21:20:46 +0000 (22:20 +0100)]
adapt tests to rank changes of natural

4 years agoguess a base address level for address rank 0 objects
Sarah Hoffmann [Sun, 25 Oct 2020 21:19:43 +0000 (22:19 +0100)]
guess a base address level for address rank 0 objects

The guess is based on the area and mainly avoids odd
addresses for very large or small objects.

4 years agoelevate most natural feature to address rank 22
Sarah Hoffmann [Fri, 23 Oct 2020 10:58:13 +0000 (12:58 +0200)]
elevate most natural feature to address rank 22

Makes them be in par with landuse features.

4 years agoMerge pull request #2032 from lonvia/remove-ui
Sarah Hoffmann [Sun, 1 Nov 2020 14:12:12 +0000 (15:12 +0100)]
Merge pull request #2032 from lonvia/remove-ui

Remove HTML output

4 years agoMerge pull request #2035 from lonvia/add-index-to-multicountry-script
Sarah Hoffmann [Sun, 1 Nov 2020 14:11:02 +0000 (15:11 +0100)]
Merge pull request #2035 from lonvia/add-index-to-multicountry-script

docs: need to index after updating with a file

4 years agodocs: need to index after updating with a file
Sarah Hoffmann [Sat, 31 Oct 2020 21:53:08 +0000 (22:53 +0100)]
docs: need to index after updating with a file

Fixes #2031.

4 years agouse simpler recurse operator for overpass download
Sarah Hoffmann [Sat, 31 Oct 2020 20:33:48 +0000 (21:33 +0100)]
use simpler recurse operator for overpass download

Also fixes a typo in the OSM link.

4 years agomake phpcs happy
Sarah Hoffmann [Thu, 29 Oct 2020 10:36:16 +0000 (11:36 +0100)]
make phpcs happy

4 years agovagrant: setting website URL is not longer necessary
Sarah Hoffmann [Tue, 27 Oct 2020 20:37:46 +0000 (21:37 +0100)]
vagrant: setting website URL is not longer necessary

4 years agoremove now unused settings related to website
Sarah Hoffmann [Tue, 27 Oct 2020 20:29:35 +0000 (21:29 +0100)]
remove now unused settings related to website

There are two places where the website URL is still used:
for icons, replace the URL with a link to the icon repository
of the UI repo. The more URL now builds the link from the
server info.

4 years agoremove tests for HTML output
Sarah Hoffmann [Tue, 27 Oct 2020 10:24:25 +0000 (11:24 +0100)]
remove tests for HTML output

4 years agoremove HTML output and UI elements
Sarah Hoffmann [Tue, 27 Oct 2020 10:05:03 +0000 (11:05 +0100)]
remove HTML output and UI elements

4 years agoremove hierarchy endpoint
Sarah Hoffmann [Tue, 27 Oct 2020 09:38:08 +0000 (10:38 +0100)]
remove hierarchy endpoint

This endpoint was never maintained and most of the information
can be obtained via the details endpoint.

4 years agoMerge pull request #2030 from lonvia/improve-ci
Sarah Hoffmann [Wed, 28 Oct 2020 14:20:40 +0000 (15:20 +0100)]
Merge pull request #2030 from lonvia/improve-ci

Small improvements for github actions run

4 years agoaction: cache downloaded dependencies
Sarah Hoffmann [Wed, 28 Oct 2020 10:54:37 +0000 (11:54 +0100)]
action: cache downloaded dependencies

4 years agoMerge pull request #2027 from lonvia/remove-duplicate-admin-boundaries
Sarah Hoffmann [Wed, 28 Oct 2020 10:11:42 +0000 (11:11 +0100)]
Merge pull request #2027 from lonvia/remove-duplicate-admin-boundaries

Handle duplicated admin boundaries

4 years agoactions: tweak database settings
Sarah Hoffmann [Wed, 28 Oct 2020 10:10:14 +0000 (11:10 +0100)]
actions: tweak database settings

Disabling fsync and friends should speed up the CI run
significantly.

4 years agouse highest admin boundary for duplicated ones
Sarah Hoffmann [Mon, 26 Oct 2020 20:11:06 +0000 (21:11 +0100)]
use highest admin boundary for duplicated ones

4 years agodisable admin level 5 in Russia
Sarah Hoffmann [Mon, 26 Oct 2020 19:17:28 +0000 (20:17 +0100)]
disable admin level 5 in Russia

They either interfere with cities or refer to historical boundaries.

4 years agominor fixes for geometry compuation during boundary ranking
Sarah Hoffmann [Fri, 23 Oct 2020 08:43:57 +0000 (10:43 +0200)]
minor fixes for geometry compuation during boundary ranking

Go back to using centroid when determining if one admin level
is within another. There are cases where boundaries are slightly
misaligned due to mapping errors (not using the same ways in the
relations).

Only declare boundaries the same when they have the same wikidata
tag _and_ have exactly the same geometry. This works around tagging
errors with the wikidata tag, which happen because of automated
edits to the wikidata tag.

4 years agodetect and remove admin boundary duplicates
Sarah Hoffmann [Tue, 20 Oct 2020 21:26:44 +0000 (23:26 +0200)]
detect and remove admin boundary duplicates

The Polish community maps admin boundaries that span multiple
levels by duplicating the boundary relations. Detect this situation
by looking out for matching wikidata tags. The higher ranked
duplicates are then thrown out from the address pool by setting
their address rank to 0.

4 years agoMerge pull request #2029 from lonvia/master
Sarah Hoffmann [Wed, 28 Oct 2020 09:12:52 +0000 (10:12 +0100)]
Merge pull request #2029 from lonvia/master

Switch CI to github actions

4 years agoswitch CI badge to github actions
Sarah Hoffmann [Wed, 28 Oct 2020 09:11:22 +0000 (10:11 +0100)]
switch CI badge to github actions

4 years agoswitch CI to github acitons
Sarah Hoffmann [Tue, 27 Oct 2020 20:49:06 +0000 (21:49 +0100)]
switch CI to github acitons

4 years agoMerge pull request #2025 from lonvia/fix-secondary-importance-for-countries
Sarah Hoffmann [Thu, 22 Oct 2020 11:43:22 +0000 (13:43 +0200)]
Merge pull request #2025 from lonvia/fix-secondary-importance-for-countries

Improve secondary result ordering for administrative boundaries

4 years agoadjust secondary order when no addressimportance available
Sarah Hoffmann [Thu, 22 Oct 2020 08:20:16 +0000 (10:20 +0200)]
adjust secondary order when no addressimportance available

In cases of countries and remote places without an address
it is possible that 'addressimportance' comes back empty.
Adjust the 'foundorder' to the places importance instead
in such cases.

Fixes #2023.

4 years agoreadd boundary:administrative to class importance
Sarah Hoffmann [Thu, 22 Oct 2020 08:16:04 +0000 (10:16 +0200)]
readd boundary:administrative to class importance

4 years agoMerge pull request #2022 from lonvia/populate-rank-25
Sarah Hoffmann [Tue, 20 Oct 2020 21:26:18 +0000 (23:26 +0200)]
Merge pull request #2022 from lonvia/populate-rank-25

reorganize ranks of high-level place types

4 years agoreorganize ranks of high-level place types
Sarah Hoffmann [Tue, 20 Oct 2020 18:20:49 +0000 (20:20 +0200)]
reorganize ranks of high-level place types

Rank 25 is now available for places that should appear in addresses
but not when a street is present. Use this for som block-like
place types. Also document the particularity of rank 25.

subdevisions and allotments are now at the same level as landuse
which they are frequently used together with.

4 years agoMerge pull request #2019 from lonvia/find-pgconfig-inpostgresql-repo
Sarah Hoffmann [Tue, 20 Oct 2020 13:02:00 +0000 (15:02 +0200)]
Merge pull request #2019 from lonvia/find-pgconfig-inpostgresql-repo

Add support for finding pg_config in Postgresql repos

4 years agoadd support for finding pg_config in Postgresql repos
Sarah Hoffmann [Tue, 20 Oct 2020 09:39:00 +0000 (11:39 +0200)]
add support for finding pg_config in Postgresql repos

It uses the same PostgreSQL_ADDITIONAL_VERSIONS variable as
osm2pgsql so that setting that should be sufficient to make
it work.

4 years agoMerge pull request #2018 from lonvia/update-osm2pgsql
Sarah Hoffmann [Tue, 20 Oct 2020 09:33:36 +0000 (11:33 +0200)]
Merge pull request #2018 from lonvia/update-osm2pgsql

Update to latest osm2pgsql

4 years agoupdate to latest osm2pgsql
Sarah Hoffmann [Tue, 20 Oct 2020 09:08:07 +0000 (11:08 +0200)]
update to latest osm2pgsql

Important changes:

* fix disabling of JIT in Postgresql
* support for finding latests Postgresql from their repos
* no longer create nodes table with flatnodes

4 years agoadd explicit bbox contains check
Sarah Hoffmann [Mon, 19 Oct 2020 08:39:01 +0000 (10:39 +0200)]
add explicit bbox contains check

Now that the containment check uses ST_Relate, we need to add
a separate bbox contains check to ensure that Postgis does the
efficient check first. Note that we still cannot get rid of the
overlap(&&) check because then Postgis will use the wrong indexes.

4 years agoMerge pull request #2016 from lonvia/locale-address-russia
Sarah Hoffmann [Sun, 18 Oct 2020 07:48:23 +0000 (09:48 +0200)]
Merge pull request #2016 from lonvia/locale-address-russia

add country-specific address ranks for Russia

4 years agoMerge pull request #2015 from lonvia/cleanup-address-computation
Sarah Hoffmann [Sun, 18 Oct 2020 07:48:05 +0000 (09:48 +0200)]
Merge pull request #2015 from lonvia/cleanup-address-computation

Rework collection of address parts

4 years agoadd country-specific address ranks for Russia
Sarah Hoffmann [Sat, 17 Oct 2020 15:54:06 +0000 (17:54 +0200)]
add country-specific address ranks for Russia

Removes admin level 7, which should not exist and promotes
admin level 8 to municipality level.

place=municipality is only used for boroughs of St. Petersburg,
so demote to level 18.

Fixes #926.

4 years agoadd tests for rank computation
Sarah Hoffmann [Sat, 17 Oct 2020 15:51:22 +0000 (17:51 +0200)]
add tests for rank computation

4 years agoadd tests for address computation
Sarah Hoffmann [Fri, 16 Oct 2020 09:07:17 +0000 (11:07 +0200)]
add tests for address computation

4 years agorevert to && comparison for geometries
Sarah Hoffmann [Fri, 16 Oct 2020 07:49:48 +0000 (09:49 +0200)]
revert to && comparison for geometries

Postgis 3 picks the wrong index when using ~ or @.

4 years agouse computed centroid for location_area_large
Sarah Hoffmann [Thu, 15 Oct 2020 15:30:52 +0000 (17:30 +0200)]
use computed centroid for location_area_large

The new address computation assumes that the centroid is inside
the area. Therefore we cannot use the centroid function. Use the
pre-computed centroid instead which has already been corrected to
be inside the area.

4 years agocorrectly set from area column in place_addressline
Sarah Hoffmann [Thu, 15 Oct 2020 10:06:53 +0000 (12:06 +0200)]
correctly set from area column in place_addressline

This was always set to true which brings us to the question
if it is even still needed.

4 years agofix use of geometry operators
Sarah Hoffmann [Thu, 15 Oct 2020 10:06:18 +0000 (12:06 +0200)]
fix use of geometry operators

@ is contained by while ~ is contains.

4 years agodemote admin boundaries for place areas
Sarah Hoffmann [Wed, 14 Oct 2020 09:33:47 +0000 (11:33 +0200)]
demote admin boundaries for place areas

Also demote the address rank of an admin boundary when there
is a place area of higher rank that completely contains the
area. This catches the case where city boundaries do not exactly
align with administrative units (see for example Moscow).

4 years agoexclude rank 25 when computing addresses of streets
Sarah Hoffmann [Tue, 13 Oct 2020 20:36:17 +0000 (22:36 +0200)]
exclude rank 25 when computing addresses of streets

Address rank 25 is used for squares which are address-wise on the
same level as streets.

4 years agooverhaul address computation
Sarah Hoffmann [Tue, 13 Oct 2020 20:10:07 +0000 (22:10 +0200)]
overhaul address computation

This is a complete rewrite of the selection of address parts to
be inserted into the place_addressline table.

The new algorithm selects for each rank:
* the boundary overlapping with the addressee and contained
  in the already selected boundaries of lower rank, or failing that
* the place node closest to the addressee that is contained in
  the already selected boundaries and in the influence radius
  of already selected place nodes of lower rank

Place nodes that are not contained in already selected boundaries
of lower rank are completely thrown away. All other candidates are
added as non-address parts.

4 years agomove ordering out of getNearFeatures
Sarah Hoffmann [Tue, 13 Oct 2020 12:57:11 +0000 (14:57 +0200)]
move ordering out of getNearFeatures

The two places where the function is called have different ordering
requirement.

4 years agoMerge pull request #2012 from lonvia/format-reverse-debug-output
Sarah Hoffmann [Tue, 13 Oct 2020 07:23:43 +0000 (09:23 +0200)]
Merge pull request #2012 from lonvia/format-reverse-debug-output

use Debug class for formatting reverse debug output

4 years agouse Debug class for formatting reverse debug output
Sarah Hoffmann [Mon, 12 Oct 2020 15:12:03 +0000 (17:12 +0200)]
use Debug class for formatting reverse debug output

4 years agoMerge pull request #2011 from lonvia/increase-city-radius
Sarah Hoffmann [Mon, 12 Oct 2020 14:17:39 +0000 (16:17 +0200)]
Merge pull request #2011 from lonvia/increase-city-radius

Increase radius of influence around city nodes

4 years agoincrease radius of influence around city nodes
Sarah Hoffmann [Mon, 12 Oct 2020 12:17:37 +0000 (14:17 +0200)]
increase radius of influence around city nodes

The current radius does not cover cities with more than a
million inhabitants well.

4 years agoMerge pull request #2004 from lonvia/demote-place-nodes-in-admin-areas
Sarah Hoffmann [Mon, 12 Oct 2020 09:54:52 +0000 (11:54 +0200)]
Merge pull request #2004 from lonvia/demote-place-nodes-in-admin-areas

demote place nodes in admin areas

4 years agowhen linking always check against original address rank
Sarah Hoffmann [Sun, 11 Oct 2020 10:29:49 +0000 (12:29 +0200)]
when linking always check against original address rank

4 years agomake housenumber interpolation tests more lenient
Sarah Hoffmann [Sun, 11 Oct 2020 08:32:35 +0000 (10:32 +0200)]
make housenumber interpolation tests more lenient

4 years agodemote place nodes in admin areas
Sarah Hoffmann [Wed, 7 Oct 2020 15:33:52 +0000 (17:33 +0200)]
demote place nodes in admin areas

If a place node of city rank and above finds itself in an
administrative boundary of the same address rank, then
increase the address rank by 2. This catches the rather
frequent case where city suburbs are tagged for historical
reasons as towns or villages.

4 years agoMerge pull request #2008 from lonvia/docs-missing-index-migration
Sarah Hoffmann [Sun, 11 Oct 2020 09:05:59 +0000 (11:05 +0200)]
Merge pull request #2008 from lonvia/docs-missing-index-migration

docs: migration to new wikipedia needs new index

4 years agodocs: migration to new wikipedia needs new index
Sarah Hoffmann [Sun, 11 Oct 2020 08:40:23 +0000 (10:40 +0200)]
docs: migration to new wikipedia needs new index

Fixes #1998.

4 years agoMerge pull request #2006 from mtmail/ubuntu-20-postgresql-contrib
Sarah Hoffmann [Sun, 11 Oct 2020 07:45:37 +0000 (09:45 +0200)]
Merge pull request #2006 from mtmail/ubuntu-20-postgresql-contrib

Ubuntu 20: use postgresql-contrib-12 so no version higher gets installed

4 years agoMerge pull request #2003 from lonvia/admin-levels-indonesia
Sarah Hoffmann [Sun, 11 Oct 2020 07:43:33 +0000 (09:43 +0200)]
Merge pull request #2003 from lonvia/admin-levels-indonesia

Adapt address levels for admin boundaries in Indonesia

4 years agoUbuntu 20: use postgresql-contrib-12 so no version higher gets installed
marc tobias [Sat, 10 Oct 2020 00:42:46 +0000 (02:42 +0200)]
Ubuntu 20: use postgresql-contrib-12 so no version higher gets installed

4 years agoadapt address levels for admin boundaries in Indonesia
Sarah Hoffmann [Fri, 9 Oct 2020 20:28:06 +0000 (22:28 +0200)]
adapt address levels for admin boundaries in Indonesia

4 years agoMerge pull request #2002 from lonvia/analyse-indexing-script
Sarah Hoffmann [Fri, 9 Oct 2020 18:23:51 +0000 (20:23 +0200)]
Merge pull request #2002 from lonvia/analyse-indexing-script

Add script for detailed explaing of indexing trigger

4 years agoadd script for detailed explaing of indexing trigger
Sarah Hoffmann [Fri, 9 Oct 2020 15:20:22 +0000 (17:20 +0200)]
add script for detailed explaing of indexing trigger

4 years agoMerge pull request #1996 from lonvia/remove-postcode-search-structured
Sarah Hoffmann [Tue, 6 Oct 2020 15:04:22 +0000 (17:04 +0200)]
Merge pull request #1996 from lonvia/remove-postcode-search-structured

Restrict postcode searches to postcode in first token

4 years agorestrict postcode searches to postcode in first token
Sarah Hoffmann [Tue, 6 Oct 2020 12:00:43 +0000 (14:00 +0200)]
restrict postcode searches to postcode in first token

In structured queries we should only assume that it is
a postcode search when only the postcode and optionally
the country is given. If any other term is present, it
is better to avoid the search for postcode as it yields
too many bad searches. Given that the terms in a structured
query are ordered, this means that the postcode must be
the first token just like in the unstructured query.

Fixes #1988.

4 years agoRevert "adapt tests to rank_search removal"
Sarah Hoffmann [Tue, 6 Oct 2020 11:59:50 +0000 (13:59 +0200)]
Revert "adapt tests to rank_search removal"

This reverts commit 2a717da8508ed697bfe6f5eded4e397054570a7a.

4 years agoMerge pull request #1995 from lonvia/update-osm2pgsql
Sarah Hoffmann [Mon, 5 Oct 2020 16:14:29 +0000 (18:14 +0200)]
Merge pull request #1995 from lonvia/update-osm2pgsql

update to latest osm2pgsql version

4 years agoupdate to latest osm2pgsql version
Sarah Hoffmann [Mon, 5 Oct 2020 15:11:13 +0000 (17:11 +0200)]
update to latest osm2pgsql version

The latest version of osm2pgsql no longer creates indexes on
the members of planet_osm_rels. So we do that ourselves.
Given that we only need to access associated street relations,
the index can become quite a bit smaller.

4 years agoMerge pull request #1986 from mtmail/document-drop-idx_placex_geometry_reverse_lookup...
Sarah Hoffmann [Mon, 5 Oct 2020 14:18:46 +0000 (16:18 +0200)]
Merge pull request #1986 from mtmail/document-drop-idx_placex_geometry_reverse_lookupPoint

migration guide: idx_placex_geometry_reverse_lookupPoint can be dropped

4 years agoMerge pull request #1993 from mtmail/country-name-eSwatini
Sarah Hoffmann [Mon, 5 Oct 2020 14:17:54 +0000 (16:17 +0200)]
Merge pull request #1993 from mtmail/country-name-eSwatini

country names: Swaziland => eSwatini

4 years agocountry names: Swaziland => eSwatini
marc tobias [Sun, 4 Oct 2020 11:38:15 +0000 (13:38 +0200)]
country names: Swaziland => eSwatini

4 years agomigration guide: idx_placex_geometry_reverse_lookupPoint can be dropped
marc tobias [Wed, 30 Sep 2020 12:28:20 +0000 (14:28 +0200)]
migration guide: idx_placex_geometry_reverse_lookupPoint can be dropped

4 years agoMerge pull request #1984 from lonvia/remove-reverse-index
Sarah Hoffmann [Wed, 30 Sep 2020 10:02:34 +0000 (12:02 +0200)]
Merge pull request #1984 from lonvia/remove-reverse-index

Remove unused idx_placex_geometry_reverse_lookupPoint

4 years agoremove removed index from database check
Sarah Hoffmann [Wed, 30 Sep 2020 09:33:15 +0000 (11:33 +0200)]
remove removed index from database check

4 years agoremove unused idx_placex_geometry_reverse_lookupPoint
Sarah Hoffmann [Wed, 30 Sep 2020 07:21:35 +0000 (09:21 +0200)]
remove unused idx_placex_geometry_reverse_lookupPoint

The index has been unused ever since the query using it was
changed two years ago. Given that it has not been missed much,
drop it completely here.

4 years agoMerge pull request #1982 from lonvia/more-rank-search-removal
Sarah Hoffmann [Sat, 26 Sep 2020 09:08:20 +0000 (11:08 +0200)]
Merge pull request #1982 from lonvia/more-rank-search-removal

More rank search removal

4 years agoadapt tests to rank_search removal
Sarah Hoffmann [Sat, 26 Sep 2020 07:10:37 +0000 (09:10 +0200)]
adapt tests to rank_search removal

4 years agoRemove more rank_search usage from address computation
Sarah Hoffmann [Fri, 25 Sep 2020 15:50:36 +0000 (17:50 +0200)]
Remove more rank_search usage from address computation

Fixes #1904.

4 years agoMerge pull request #1980 from lonvia/add-descriptive-term-for-address-rank-24
Sarah Hoffmann [Fri, 25 Sep 2020 14:56:35 +0000 (16:56 +0200)]
Merge pull request #1980 from lonvia/add-descriptive-term-for-address-rank-24

add descriptive term for address rank 24

4 years agoadd descriptive term for address rank 24
Sarah Hoffmann [Fri, 25 Sep 2020 14:02:17 +0000 (16:02 +0200)]
add descriptive term for address rank 24

With that term we have terms for all ranks, so that no generic
'administrative' term will show up in the address details anymore.

4 years agoMerge pull request #1975 from lonvia/simplify-parent-assignment-for-unlisted-places
Sarah Hoffmann [Wed, 23 Sep 2020 17:10:42 +0000 (19:10 +0200)]
Merge pull request #1975 from lonvia/simplify-parent-assignment-for-unlisted-places

Use closest containing place area for parent of unlisted addr:place

4 years agoMerge pull request #1970 from lonvia/remove-duplicate-geometry-check
Sarah Hoffmann [Wed, 23 Sep 2020 16:51:35 +0000 (18:51 +0200)]
Merge pull request #1970 from lonvia/remove-duplicate-geometry-check

Switch recursive updates to using rank_search

4 years agouse rank_address when invalidating containing objects
Sarah Hoffmann [Tue, 22 Sep 2020 14:34:28 +0000 (16:34 +0200)]
use rank_address when invalidating containing objects

Only rank_address is now relevant for determining if a place
could be part of an address.

4 years agoremove ST_Covers check when also testing for ST_Intersects
Sarah Hoffmann [Tue, 22 Sep 2020 13:51:04 +0000 (15:51 +0200)]
remove ST_Covers check when also testing for ST_Intersects

Using both is slightly problematic because they have different
ways to use the index. Newer versions of Postgis exhibit a
query planner issue when both functions appear together.
As ST_Intersects includes ST_Covers, simply remove the latter.

4 years agouse closest containing place for unlisted addr:place
Sarah Hoffmann [Wed, 23 Sep 2020 15:33:42 +0000 (17:33 +0200)]
use closest containing place for unlisted addr:place

We can't use getNearFeatures() to determine the parent of a
place with an unlisted addr:place because this function
returns place nodes that are potentially outside the area
of interest. Doing the complete address computation is too
expensive, so simply use the area with the largest rank that
contains the feature instead.

4 years agoMerge pull request #1974 from lonvia/show-unknown-addr-place
Sarah Hoffmann [Wed, 23 Sep 2020 13:26:12 +0000 (15:26 +0200)]
Merge pull request #1974 from lonvia/show-unknown-addr-place

add unknown addr:place to address output

4 years agoadd unknown addr:place to address output
Sarah Hoffmann [Wed, 23 Sep 2020 09:55:18 +0000 (11:55 +0200)]
add unknown addr:place to address output

When a POI has no addr:street but an addr:place that is not
contained in the name list of the parent place, then remember
this situation and merge the content of addr:place into the
address output.

We don't need to care about translations in this case because
it is obvious that no object with translations exists if the
parent isn't the object named in addr:place.

4 years agoMerge pull request #1971 from lonvia/drop-support-for-isin
Sarah Hoffmann [Wed, 23 Sep 2020 07:20:35 +0000 (09:20 +0200)]
Merge pull request #1971 from lonvia/drop-support-for-isin

Drop support for is_in tag

4 years agoMerge pull request #1972 from lonvia/exclude-unnamed-highway-areas
Sarah Hoffmann [Wed, 23 Sep 2020 07:20:16 +0000 (09:20 +0200)]
Merge pull request #1972 from lonvia/exclude-unnamed-highway-areas

Exclude unnamed highway areas

4 years agoexclude unnamed highway areas
Sarah Hoffmann [Tue, 22 Sep 2020 11:27:05 +0000 (13:27 +0200)]
exclude unnamed highway areas

These are used to mark large paved areas. Sometimes they exists
together with named regular streets. In such cases the unnamed
area may overshadow the actual street when computing the address
parent. As unnamed highways are not very useful anyway, we
simply remove them from the database.