]> git.openstreetmap.org Git - nominatim.git/log
nominatim.git
17 months agoalso switch legacy tokenizer to new street/place choice behaviour
Sarah Hoffmann [Fri, 30 Jun 2023 13:28:00 +0000 (15:28 +0200)]
also switch legacy tokenizer to new street/place choice behaviour

17 months agofix optional string representation or repr(PlaceName)
Sarah Hoffmann [Thu, 29 Jun 2023 20:02:55 +0000 (22:02 +0200)]
fix optional string representation or repr(PlaceName)

17 months agouse information from tokenizer to determine street vs. place address
Sarah Hoffmann [Fri, 30 Jun 2023 09:08:25 +0000 (11:08 +0200)]
use information from tokenizer to determine street vs. place address

So far the SQL logic used the information from the address field
to determine if an address is attached to a street or place.
This changes the logic to use the information provided in the
token_info. This allows sanitizers to enforce a certain parenting
without changing the visible address information.

18 months agoMerge pull request #3094 from lonvia/fix-failing-bdd-tests
Sarah Hoffmann [Thu, 22 Jun 2023 20:28:31 +0000 (22:28 +0200)]
Merge pull request #3094 from lonvia/fix-failing-bdd-tests

Add BDD tests against Python frontend to CI

18 months agoMerge pull request #3090 from mtmail/check-database-on-frozen-database
Sarah Hoffmann [Thu, 22 Jun 2023 18:11:30 +0000 (20:11 +0200)]
Merge pull request #3090 from mtmail/check-database-on-frozen-database

check-database on frozen db shouldnt recommend indexing

18 months agoadd python frontend tests to CI
Sarah Hoffmann [Thu, 22 Jun 2023 15:29:44 +0000 (17:29 +0200)]
add python frontend tests to CI

18 months agoslightly adapt postcode tests
Sarah Hoffmann [Thu, 22 Jun 2023 14:51:59 +0000 (16:51 +0200)]
slightly adapt postcode tests

18 months agobdd: fix faking HTTP headers for python web frameworks
Sarah Hoffmann [Wed, 21 Jun 2023 09:33:42 +0000 (11:33 +0200)]
bdd: fix faking HTTP headers for python web frameworks

18 months agoMerge branch 'osm-search:master' into check-database-on-frozen-database
mtmail [Thu, 22 Jun 2023 10:14:55 +0000 (12:14 +0200)]
Merge branch 'osm-search:master' into check-database-on-frozen-database

18 months agomove text normalization into extra function
Sarah Hoffmann [Thu, 22 Jun 2023 08:48:05 +0000 (10:48 +0200)]
move text normalization into extra function

18 months agoMerge pull request #3093 from lonvia/remove-sanic
Sarah Hoffmann [Thu, 22 Jun 2023 07:55:32 +0000 (09:55 +0200)]
Merge pull request #3093 from lonvia/remove-sanic

Remove support for Sanic

18 months agocheck-database on frozen db shouldnt recommend indexing
Marc Tobias [Mon, 19 Jun 2023 16:43:17 +0000 (18:43 +0200)]
check-database on frozen db shouldnt recommend indexing

18 months agouse in operator for enum tests
Sarah Hoffmann [Wed, 21 Jun 2023 13:30:40 +0000 (15:30 +0200)]
use in operator for enum tests

Fixes a complaint by mypy.

18 months agoremove useless check
Sarah Hoffmann [Wed, 21 Jun 2023 09:56:39 +0000 (11:56 +0200)]
remove useless check

Found by new mypy version.

18 months agoremove support for sanic framework
Sarah Hoffmann [Wed, 21 Jun 2023 08:53:57 +0000 (10:53 +0200)]
remove support for sanic framework

There is no performance gain over falcon or starlette but the special
structure of sanic makes it hard to have exchangable code

18 months agoupdate project information for taginfo.json
Sarah Hoffmann [Wed, 21 Jun 2023 08:06:25 +0000 (10:06 +0200)]
update project information for taginfo.json

18 months agoMerge pull request #3045 from biswajit-k/taginfo
Sarah Hoffmann [Wed, 21 Jun 2023 08:01:40 +0000 (10:01 +0200)]
Merge pull request #3045 from biswajit-k/taginfo

Add script to generate taginfo project description

18 months agoMerge pull request #3091 from lonvia/fix-postcode-search
Sarah Hoffmann [Tue, 20 Jun 2023 14:13:20 +0000 (16:13 +0200)]
Merge pull request #3091 from lonvia/fix-postcode-search

Assorted smaller fixes for Python-based search code

18 months agoavoid fallback country lookup when places are excluded
Sarah Hoffmann [Tue, 20 Jun 2023 10:22:08 +0000 (12:22 +0200)]
avoid fallback country lookup when places are excluded

18 months agoallow empty parts in excluded_place_id
Sarah Hoffmann [Tue, 20 Jun 2023 09:33:35 +0000 (11:33 +0200)]
allow empty parts in excluded_place_id

This worked before.

18 months agofix header name for browser languages
Sarah Hoffmann [Tue, 20 Jun 2023 09:09:44 +0000 (11:09 +0200)]
fix header name for browser languages

18 months agotweak postcode search
Sarah Hoffmann [Tue, 20 Jun 2023 08:54:04 +0000 (10:54 +0200)]
tweak postcode search

Give a preference to left-right reading, i.e <postcode>,<address>
prefers a postcode search while <address>,<postcode> rather does
an address search.

Also exclude non-addressables, countries and state from results when a
postcode is contained in the query.

18 months agouse string representation when dumping variables
Sarah Hoffmann [Tue, 20 Jun 2023 08:15:51 +0000 (10:15 +0200)]
use string representation when dumping variables

18 months agofix debug output for searches
Sarah Hoffmann [Tue, 20 Jun 2023 08:12:19 +0000 (10:12 +0200)]
fix debug output for searches

Fields have been renamed.

18 months agoMerge pull request #3086 from lonvia/close-connection-on-replication
Sarah Hoffmann [Mon, 19 Jun 2023 13:48:00 +0000 (15:48 +0200)]
Merge pull request #3086 from lonvia/close-connection-on-replication

Close database connections while waiting for the next update cycle

18 months agoMerge pull request #3087 from lonvia/conditional-spgist
Sarah Hoffmann [Mon, 19 Jun 2023 13:47:37 +0000 (15:47 +0200)]
Merge pull request #3087 from lonvia/conditional-spgist

Disable SPGist for PostgreSQL < 11

18 months agoMerge pull request #3085 from lonvia/allow-brackets-in-password
Sarah Hoffmann [Mon, 19 Jun 2023 12:44:22 +0000 (14:44 +0200)]
Merge pull request #3085 from lonvia/allow-brackets-in-password

Do not fail php script generation when curly braces are present

18 months agono longer recommend continuous update mode
Sarah Hoffmann [Mon, 19 Jun 2023 10:07:09 +0000 (12:07 +0200)]
no longer recommend continuous update mode

18 months agoclose DB connection when waiting for next update cycle
Sarah Hoffmann [Mon, 19 Jun 2023 10:02:51 +0000 (12:02 +0200)]
close DB connection when waiting for next update cycle

18 months agodo not fail php script generation when curly braces are present
Sarah Hoffmann [Mon, 19 Jun 2023 09:23:30 +0000 (11:23 +0200)]
do not fail php script generation when curly braces are present

Fixes #3084.

18 months agoAdd custom config to information required for bug reports
Sarah Hoffmann [Sun, 18 Jun 2023 07:27:55 +0000 (09:27 +0200)]
Add custom config to information required for bug reports

18 months agodisable SPGist for PostgreSQL < 11
Sarah Hoffmann [Tue, 13 Jun 2023 13:15:43 +0000 (15:15 +0200)]
disable SPGist for PostgreSQL < 11

Before that version, an operator needed to be given.

18 months agoadd instructions for switching to user for install scripts
Sarah Hoffmann [Tue, 13 Jun 2023 12:12:56 +0000 (14:12 +0200)]
add instructions for switching to user for install scripts

Fixes #3057.

18 months agoremove Ubuntu 18 installation from TOC
Sarah Hoffmann [Tue, 13 Jun 2023 12:05:54 +0000 (14:05 +0200)]
remove Ubuntu 18 installation from TOC

Fixes #3072.

18 months agoMerge pull request #3073 from mtmail/vagrantfile-remove-ubuntu-18
Sarah Hoffmann [Tue, 13 Jun 2023 10:31:10 +0000 (12:31 +0200)]
Merge pull request #3073 from mtmail/vagrantfile-remove-ubuntu-18

Vagrantfile - remove Ubuntu 18

18 months agoVagrantfile - remove Ubuntu 18
marc tobias [Mon, 29 May 2023 22:22:18 +0000 (00:22 +0200)]
Vagrantfile - remove Ubuntu 18

18 months agoMerge pull request #3067 from lonvia/python-search-api
Sarah Hoffmann [Sat, 27 May 2023 06:56:06 +0000 (08:56 +0200)]
Merge pull request #3067 from lonvia/python-search-api

Python implementation of Search API

18 months agomake code backwards-compatible with older Python versions
Sarah Hoffmann [Fri, 26 May 2023 16:09:03 +0000 (18:09 +0200)]
make code backwards-compatible with older Python versions

18 months agoremove tests for old PHP cli commands
Sarah Hoffmann [Fri, 26 May 2023 15:36:05 +0000 (17:36 +0200)]
remove tests for old PHP cli commands

18 months agofix new linting warning
Sarah Hoffmann [Fri, 26 May 2023 14:31:43 +0000 (16:31 +0200)]
fix new linting warning

18 months agofix various failing BDD tests
Sarah Hoffmann [Fri, 26 May 2023 13:08:48 +0000 (15:08 +0200)]
fix various failing BDD tests

18 months agoadd support for search by houenumber
Sarah Hoffmann [Fri, 26 May 2023 12:10:57 +0000 (14:10 +0200)]
add support for search by houenumber

18 months agoignore name rankings without variants
Sarah Hoffmann [Fri, 26 May 2023 09:52:27 +0000 (11:52 +0200)]
ignore name rankings without variants

18 months agoproperly close connections when shutting down starlette
Sarah Hoffmann [Fri, 26 May 2023 09:44:25 +0000 (11:44 +0200)]
properly close connections when shutting down starlette

18 months agofix geocodejson address assignment
Sarah Hoffmann [Fri, 26 May 2023 09:43:11 +0000 (11:43 +0200)]
fix geocodejson address assignment

The categories should be assigned the address part with the
highest address rank not lowest.

18 months agoadd server fronting for search endpoint
Sarah Hoffmann [Fri, 26 May 2023 09:40:45 +0000 (11:40 +0200)]
add server fronting for search endpoint

This also implements some of the quirks of free-text search of the
V1 API, in particular, search for categories and coordinates.

18 months agoadd timestamps to HTML debug output
Sarah Hoffmann [Fri, 26 May 2023 07:05:44 +0000 (09:05 +0200)]
add timestamps to HTML debug output

18 months agomingle names from linked places into results
Sarah Hoffmann [Wed, 24 May 2023 21:17:15 +0000 (23:17 +0200)]
mingle names from linked places into results

18 months agoswitch CLI search command to python implementation
Sarah Hoffmann [Wed, 24 May 2023 20:54:54 +0000 (22:54 +0200)]
switch CLI search command to python implementation

18 months agomake localisation of results explicit
Sarah Hoffmann [Wed, 24 May 2023 16:12:34 +0000 (18:12 +0200)]
make localisation of results explicit

Localisation was previously done as part of the formatting but might
also be useful on its own when working with the results directly.

18 months agoadd API functions for search functions
Sarah Hoffmann [Wed, 24 May 2023 15:43:28 +0000 (17:43 +0200)]
add API functions for search functions

Search is now split into three functions: for free-text search,
for structured search and for search by category. Note that the
free-text search does not have as many hidden features like
coordinate search. Use the search parameters for that.

19 months agoimplement actual database searches
Sarah Hoffmann [Wed, 24 May 2023 11:52:31 +0000 (13:52 +0200)]
implement actual database searches

19 months agoimplement search builder
Sarah Hoffmann [Tue, 23 May 2023 09:20:34 +0000 (11:20 +0200)]
implement search builder

19 months agoimplement token assignment
Sarah Hoffmann [Mon, 22 May 2023 13:49:03 +0000 (15:49 +0200)]
implement token assignment

19 months agoadd query analyser for legacy tokenizer
Sarah Hoffmann [Mon, 22 May 2023 09:07:14 +0000 (11:07 +0200)]
add query analyser for legacy tokenizer

19 months agoadd factory for query analyzer
Sarah Hoffmann [Mon, 22 May 2023 07:23:19 +0000 (09:23 +0200)]
add factory for query analyzer

19 months agoquery analyzer for ICU tokenizer
Sarah Hoffmann [Mon, 22 May 2023 06:46:19 +0000 (08:46 +0200)]
query analyzer for ICU tokenizer

19 months agoadd ci-test for taginfo file generation
biswajit-k [Sun, 21 May 2023 18:19:04 +0000 (23:49 +0530)]
add ci-test for taginfo file generation

19 months agoadd data structure for tokenized query
Sarah Hoffmann [Sat, 20 May 2023 21:46:15 +0000 (23:46 +0200)]
add data structure for tokenized query

19 months agodocs: add installation instruction for dkjson package
biswajit-k [Fri, 19 May 2023 17:52:42 +0000 (23:22 +0530)]
docs: add installation instruction for dkjson package

19 months agoAdd script to generate taginfo project description
biswajit-k [Wed, 26 Apr 2023 18:14:20 +0000 (23:44 +0530)]
Add script to generate taginfo project description

19 months agoMerge pull request #3064 from lonvia/clicmd-debug-output
Sarah Hoffmann [Fri, 19 May 2023 06:55:26 +0000 (08:55 +0200)]
Merge pull request #3064 from lonvia/clicmd-debug-output

Enable debug output on command line

19 months agoenable debug output on command line
Sarah Hoffmann [Thu, 18 May 2023 20:37:46 +0000 (22:37 +0200)]
enable debug output on command line

19 months agoMerge pull request #3063 from lonvia/variable-parameters
Sarah Hoffmann [Thu, 18 May 2023 20:27:18 +0000 (22:27 +0200)]
Merge pull request #3063 from lonvia/variable-parameters

Rework how search parameters are handed to the Python API

19 months agofix use of subquery in reverse
Sarah Hoffmann [Thu, 18 May 2023 18:27:07 +0000 (20:27 +0200)]
fix use of subquery in reverse

19 months agomove zoom_to_rank computation to extra file
Sarah Hoffmann [Thu, 18 May 2023 16:29:41 +0000 (18:29 +0200)]
move zoom_to_rank computation to extra file

19 months agoadd tests for parameter converter
Sarah Hoffmann [Thu, 18 May 2023 16:09:07 +0000 (18:09 +0200)]
add tests for parameter converter

19 months agoMerge pull request #3062 from lonvia/enable-psycopg
Sarah Hoffmann [Thu, 18 May 2023 16:07:11 +0000 (18:07 +0200)]
Merge pull request #3062 from lonvia/enable-psycopg

Add support for psycopg 3 in the frontend

19 months agoswitch API parameters to keyword arguments
Sarah Hoffmann [Thu, 18 May 2023 15:42:23 +0000 (17:42 +0200)]
switch API parameters to keyword arguments

This switches the input parameters for API calls to a generic
keyword argument catch-all which is then loaded into a dataclass
where the parameters are checked and forwarded to internal
function.

The dataclass gives more flexibility with the parameters and makes
it easier to reuse common parameters for the different API calls.

19 months agoactions: run tests against psycopg
Sarah Hoffmann [Thu, 18 May 2023 11:03:03 +0000 (13:03 +0200)]
actions: run tests against psycopg

19 months agoenable API use with psycopg 3
Sarah Hoffmann [Thu, 18 May 2023 11:00:59 +0000 (13:00 +0200)]
enable API use with psycopg 3

19 months agoMerge pull request #3050 from mtmail/tiger-check-if-database-frozen
Sarah Hoffmann [Mon, 8 May 2023 14:35:31 +0000 (16:35 +0200)]
Merge pull request #3050 from mtmail/tiger-check-if-database-frozen

when adding Tiger data, check first if database is in frozen state

19 months agowhen adding Tiger data, check first if database is in frozen state
Marc Tobias [Tue, 2 May 2023 16:37:36 +0000 (18:37 +0200)]
when adding Tiger data, check first if database is in frozen state

19 months agoMerge pull request #3054 from lonvia/add-amenity-to-documentation
Sarah Hoffmann [Mon, 8 May 2023 09:12:17 +0000 (11:12 +0200)]
Merge pull request #3054 from lonvia/add-amenity-to-documentation

Docs: reintroduce amenity parameter for structured search

19 months agodocs: reintroduce amenity parameter for structured search
Sarah Hoffmann [Mon, 8 May 2023 08:24:12 +0000 (10:24 +0200)]
docs: reintroduce amenity parameter for structured search

20 months agoMerge pull request #3006 from biswajit-k/generalize-filter
Sarah Hoffmann [Tue, 11 Apr 2023 17:20:08 +0000 (19:20 +0200)]
Merge pull request #3006 from biswajit-k/generalize-filter

generalize filter function for sanitizers

20 months agoMerge pull request #3030 from lonvia/interpolation-corner-cases
Sarah Hoffmann [Fri, 7 Apr 2023 11:59:52 +0000 (13:59 +0200)]
Merge pull request #3030 from lonvia/interpolation-corner-cases

Fix a number of corner cases with interpolation splitting

20 months agofix a number of corner cases with interpolation splitting
Sarah Hoffmann [Thu, 6 Apr 2023 14:54:00 +0000 (16:54 +0200)]
fix a number of corner cases with interpolation splitting

Snapping a line to a point before splitting was meant to ensure
that the split point is really on the line. However, ST_Snap() does
not always behave well for this case. It may shorten the interpolation
line in some cases with the result that two points housenumbers
suddenly fall on the same point. It might also shorten the line down
to a single point which then makes ST_Split() crash.

Switch to a combination of ST_LineLocatePoint and ST_LineSubString
instead, which guarantees to keep the original geometry. Explicitly
handle the corner cases, where the split point falls on the beginning
or end of the line.

20 months agouse place_to_be_deleted when force deleting objects
Sarah Hoffmann [Tue, 4 Apr 2023 09:09:17 +0000 (11:09 +0200)]
use place_to_be_deleted when force deleting objects

20 months agoMerge pull request #3023 from lonvia/lookup-api
Sarah Hoffmann [Mon, 3 Apr 2023 14:20:47 +0000 (16:20 +0200)]
Merge pull request #3023 from lonvia/lookup-api

Python implementation of Lookup API

20 months agoswitch CLI lookup command to Python implementation
Sarah Hoffmann [Mon, 3 Apr 2023 12:38:40 +0000 (14:38 +0200)]
switch CLI lookup command to Python implementation

20 months agoadd lookup call to server glue
Sarah Hoffmann [Mon, 3 Apr 2023 10:11:23 +0000 (12:11 +0200)]
add lookup call to server glue

20 months agoadd tests for new lookup API
Sarah Hoffmann [Mon, 3 Apr 2023 09:23:51 +0000 (11:23 +0200)]
add tests for new lookup API

20 months agorename lookup() API to details and add lookup call
Sarah Hoffmann [Mon, 3 Apr 2023 09:11:11 +0000 (11:11 +0200)]
rename lookup() API to details and add lookup call

The initial plan to serve /details and /lookup endpoints from
the same API call turned out to be impractical, so the API now
also has deparate functions for both.

20 months agopython lookup: add function for simple lookups
Sarah Hoffmann [Mon, 3 Apr 2023 08:40:38 +0000 (10:40 +0200)]
python lookup: add function for simple lookups

20 months agopython lookup: factor out finding in tables into own function
Sarah Hoffmann [Mon, 3 Apr 2023 08:00:42 +0000 (10:00 +0200)]
python lookup: factor out finding in tables into own function

20 months agoMerge pull request #3021 from lonvia/readd-postalcode-relations
Sarah Hoffmann [Mon, 3 Apr 2023 10:11:49 +0000 (12:11 +0200)]
Merge pull request #3021 from lonvia/readd-postalcode-relations

Flex style: reinstate postalcode relations

20 months agobdd: disable detail tests searching by place ID
Sarah Hoffmann [Mon, 3 Apr 2023 08:07:06 +0000 (10:07 +0200)]
bdd: disable detail tests searching by place ID

Place IDs are not stable and cannot be used in tests.

20 months agoflex style: reinstate postcode boundaries
Sarah Hoffmann [Mon, 3 Apr 2023 07:17:50 +0000 (09:17 +0200)]
flex style: reinstate postcode boundaries

Postcode boundaries don't have a name, so need to be imported
unconditionally.

20 months agogeneralize filter for sanitizers
biswajit-k [Sat, 11 Mar 2023 08:22:07 +0000 (13:52 +0530)]
generalize filter for sanitizers

20 months agoMerge pull request #3019 from lonvia/add-data-postprocessing
Sarah Hoffmann [Fri, 31 Mar 2023 20:19:46 +0000 (22:19 +0200)]
Merge pull request #3019 from lonvia/add-data-postprocessing

Add postprocessing to add-data function

20 months agocall osm2pgsql postprocessing flush_deleted_places() when adding data
Sarah Hoffmann [Tue, 28 Mar 2023 12:48:41 +0000 (14:48 +0200)]
call osm2pgsql postprocessing flush_deleted_places() when adding data

20 months agoMerge pull request #3020 from lonvia/reverse-api
Sarah Hoffmann [Fri, 31 Mar 2023 16:01:50 +0000 (18:01 +0200)]
Merge pull request #3020 from lonvia/reverse-api

Python implementation of reverse

20 months agolimit results for country lookup
Sarah Hoffmann [Thu, 30 Mar 2023 07:58:02 +0000 (09:58 +0200)]
limit results for country lookup

20 months agoadd BDD tests for new layers parameter
Sarah Hoffmann [Wed, 29 Mar 2023 18:49:34 +0000 (20:49 +0200)]
add BDD tests for new layers parameter

20 months agopython reverse: add support for point geometries in interpolations
Sarah Hoffmann [Wed, 29 Mar 2023 15:21:33 +0000 (17:21 +0200)]
python reverse: add support for point geometries in interpolations

20 months agoadd wsgi entry point for falcon server
Sarah Hoffmann [Tue, 28 Mar 2023 13:05:52 +0000 (15:05 +0200)]
add wsgi entry point for falcon server

20 months agoadd wsgi entry point for starlette
Sarah Hoffmann [Tue, 28 Mar 2023 13:03:00 +0000 (15:03 +0200)]
add wsgi entry point for starlette

uvicorn needs a parameter-free function to start.

20 months agoignore broken data in interpolation table
Sarah Hoffmann [Tue, 28 Mar 2023 12:57:39 +0000 (14:57 +0200)]
ignore broken data in interpolation table

20 months agodisable prepared statements
Sarah Hoffmann [Tue, 28 Mar 2023 12:53:45 +0000 (14:53 +0200)]
disable prepared statements

Prepared statements do not work well with the partial indexes that
Nominatim uses because all Python constants are replaced with
parameters. A query like:

  placex.select().where(placex.c.rank_address.between(4, 25)

gets translated into a prepared query with two parameters:

  SELECT * FROM placex WHERE rank_address BETWEEN %s and %s

And this does not work with a partial index of:

  CREATE INDEX on placex(geometry) WHERE rank_address between 4 and 25